[Bug]: get exception 'Star' object has no attribute 'upper' about mindsdb HOT 1 OPEN

This error is reproducible as per the instructions provided.

While debugging the issue the error generates from the mindsdb_sql package sqlalchemy_render.py. The following queries were ran to get the query_ast and type(query_ast) in the file mindsdb/api/executor/utilities/sql.py line 171 and checking the value for t in file mindsdb_sql/render/sqlalchemy_render.py line: 375

The results are:

Input (Error):

select x.* from mindsdb.models as x

query_ast ------> SELECT * FROM df AS x WHERE `project` = 'mindsdb'

type(query_ast): ------> <class 'mindsdb_sql.parser.ast.select.select.Select'>

t: ------> Identifier:<*>

Input (No Error):

select * from mindsdb.models as x

query_ast ------> SELECT * FROM df AS x WHERE `project` = 'mindsdb'

type(query_ast): ------> <class 'mindsdb_sql.parser.ast.select.select.Select'>

t: ------> Star:<*>

I have added a simple check for the input to verify if it is of type string in sqlalchemy_render.py

#### Line 117 - 123
elif isinstance(t, ast.Identifier):
            # sql functions
            col = None
            if len(t.parts) == 1 and isinstance(t, str):
                name = t.parts[0].upper()
                if name == 'CURRENT_DATE':
                    col = sa_fnc.current_date()

which resolves the issue. But a moderator can guide if this is an issue with the library mindsdb_sql and the issue should be moved there or further investigation is required to make the behavior consistent for passing the Star objects with/without alias

from mindsdb.