Code Monkey home page Code Monkey logo

Comments (6)

Milad-Akarie avatar Milad-Akarie commented on May 10, 2024

Hey @fedotxxl is there a good reason why we should do that? I'm not sure if it's helpful

from auto_route_library.

fedotxxl avatar fedotxxl commented on May 10, 2024

Why did you choose only after one more param you generate Arguments class? May be 2 params is also simple? It's unexpected that for X params system works one way and for Y - another.

You know this behavior and you are ok with it. But I preferer always use Arguments class because:

  • it makes code clear
  • I wanna use the same approach everywhere and don't think "Does my page have single param or 2+?"

from auto_route_library.

fedotxxl avatar fedotxxl commented on May 10, 2024

You know this behaviour and you are ok with it.

I mean when you know something you don't see any problems with it... After 2-5 apps I will also just use it without any worries... But now (when I'm new to API) it looks strange for me. If it's a technical restriction then I'm totally ok with the current version. If it's just to remove if (paramsCount > 1) - I don't understand why not just to remove it

from auto_route_library.

Milad-Akarie avatar Milad-Akarie commented on May 10, 2024

as I said for the sake of simplicity, But I guess you have a valid point.

from auto_route_library.

edwardaux avatar edwardaux commented on May 10, 2024

FWIW, I also stumbled over this recently. It took me ages to figure out why it wasn't working... it was only when I started poking around in the generated code that I realised what was going on.

from auto_route_library.

Milad-Akarie avatar Milad-Akarie commented on May 10, 2024

@fedotxxl @edwardaux Even single parameters routes will have their arguments holder class now, Check it out!
auto_route: 0.4.3
auto_route_generator: 0.4.3

from auto_route_library.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.