mikolajdobrucki / material-foundation Goto Github PK

The project should be under an org and the fork of @d0whc3r should be merged and the release for npmjs should come from this new repo.

I followed the installation instructions but I get this error when I run grunt:

Running "sass:dist" (sass) task
Error: File to import not found or unreadable: ../bower_components/foundation-sites/scss/util/util.
        on line 2 of scss/_foudation-util.scss
        from line 7 of scss/material-foundation.scss
        from line 2 of scss/demo.scss
  Use --trace for backtrace.
Error: File to import not found or unreadable: ../bower_components/foundation-sites/scss/util/util.
        on line 2 of scss/_foudation-util.scss
        from line 7 of scss/material-foundation.scss
  Use --trace for backtrace.
Warning: Exited with error code 65 Use --force to continue.

Aborted due to warnings.

The checkbox icon is not working in Firefox 52.6, I'm attaching an image taken from the demo site.

Fonts icon not found on your demo page
"NetworkError: 404 Not Found - http://eucalyptuss.github.io/material-foundation/fonts/icons.ttf?xw86cn"

Bower is dead, we should move the dependencies to the package.json file.

Please ignore node modules, cant even clone it to do a pull recuest because the filename is too long in windows 10.

Thanks! Your project looks nice!

If I enable the ripple js, there is a nice ripple effect on links (<a>) that have .button class. But the links do not work anymore.

After commenting out the following in ripple.js, the links are working and ripple effect stays.

event.preventDefault();

The reason for this line is probably to prevent the scroll to top on links/buttons that do not point to an address? Maybe we can check for a href="[not #]" or something?

"Foudation" is misspelled and needs to be changed to "Foundation" in the image in the readme and on the http://eucalyptuss.github.io/material-foundation/ webpage.

The latest commit of the compiled CSS appears to be just a error backtrace instead of well formed CSS:

https://github.com/eucalyptuss/material-foundation/blob/a3b69152de4b7e1def6c04f178b6954dfe60dadf/css/material-foundation.css

The placeholder-shown pseudoclass that was added here is not available on any version of the Microsoft browsers that I'm aware of.

Additionally, this change caused an undocumented behavior in browsers that do support it: now only inputs non-empty placeholders get the automatic label movement animation. This is even more unexpected because the current version of the project demo page does not have this issue.

You can simply add a git tag to a commit. Github will create a release from it.

material-design-iconic-font is not actively maintained.

https://github.com/Templarian/MaterialDesign combined with the original font by Google should be much better.

Icons should be part of a separate repository. At the moment the MaterialDesign repository is the biggest one by the community and should be preferred.

Describe how people can include the official Google Material Icons and the linked repository.

This import is relative to another package, it does not work if bower directory is other than default, which is my case in some projects.

@import '../bower_components/foundation-sites/scss/util/util';

Perhaps I'm using it incorrectly, but the floating label goes below the text area instead of above it.

<div class="small-12 medium-6 columns" style="float:left;">
    <textarea class="with-floating-label" id="description" name="description" rows="3">Test Test</textarea>        
  <label class="floating-label" for="description">Company Description</label>  
    </div>

Error: File to import not found or unreadable: ../bower_components/foundation-sites-6/scss/util/util

/foundation-sites-6/
should be
/foundation-sites/

I was hoping to take a look at the repo as I have a class project that I am working on and wanted to use this repo as a basis and extend with custom styles and functionality. After cloning I attempted to run Grunt and was presented with the error: "Fatal error: Unable to find Gruntfile".

Then I realized that there is no grunt file in the root. I have codekit and tried importing the project in there since you have the codekit config file in there, but I also had errors doing that... Haha

Could you upload your gruntfile so that I can see the project in action?

Thanks,

Angelo

ZURB Foundation's off-canvas system allows you to add a data-content-scroll="false" attribute to your off-canvas HTML wrapper. This locks the scrolling of the on off-canvas-content. I tested it, it works, so good.

In Material Foundation the data-content-scroll="false" attribute does not work--it doesn't seem to do anything.

Any fixes, work-arounds, or ideas that can make data-content-scroll work in Material Foundation?

At the moment there are import statements like:

@import "../../node_modules/material-design-iconic-font/scss/material-design-iconic-font.scss";

in "material-foundation/scss/style/_icons.scss" and other files which point to a non existing node_modules folder.

Please remove the relative module paths either by
a) using Webpack and changing all imports to "~node_modules/..."
or
b) using a "Tilde" plugin for Sass/Grunt/Gulp and also changing all imports to "~node_modules/..."

I like your material-foundation very much.

The main entry is pointing to

"./js/src",

which does not exist.

Maybe just use main: false.

Hi,
The radio button, checkboxes and switches are not working if they are inside a form.

You can see the errors in the kitchen-sink.html

Good job by the way :)

There is scss/_foudation.scss.

Webpack is the new way. We can replace Grunt with webpack as Grunt just gets very few updates.

Multiple radio buttons with the same name can be checked at any time; thus defeating the purpose of having radio buttons as opposed to checkboxes.

Hello,

Getting this error when turning flex on.

Error: Properties are only allowed within rules, directives, mixin includes, or other properties.
on line 80 of bower_components/foundation-sites/scss/components/_top-bar.scss
from line 36 of scss/material-foundation.scss
Use --trace for backtrace.
Error: Properties are only allowed within rules, directives, mixin includes, or other properties.
on line 80 of bower_components/foundation-sites/scss/components/_top-bar.scss
from line 36 of scss/material-foundation.scss
from line 2 of scss/demo.scss
Use --trace for backtrace.

Suggestions?