mikegu721 / cs_arxiv_everyweek Goto Github PK

First of all, I would like to thank for your great work for catching arxiv paper. Previously, I had written my own conversion processes for xls2csv and xls2xlsx to facilitate previewing in VS Code. I was planning to submit a pull request to address an issue, but I noticed that you have already updated this part of the code. Thank you for updating the project and keeping it well-maintained! But I noticed that there seems to be some small bugs in your conversion file xls_2_csv.py.

Issue Description

1. Missing check when creating directories.

2. The program continues to convert xls files to csv even if the csv file already exists. This appears to be due to the file existence check not being triggered correctly.

Problematic Code

line 23 os.makedirs(to_dir_file) should be os.makedirs(to_dir_file,exist_ok=True)

line 27

if os.path.exists(from_dir_file.replace(from_dir, to_dir)): continue

In the code above, the part from_dir_file.replace(from_dir, to_dir) may not be handling the path correctly, causing the os.path.exists call to fail in correctly checking if the file already exists.

Corrected to:

if os.path.exists(to_dir_file): continue

This modification ensures that the path is handled correctly and the existence check functions as intended.

Best regards.