mikaylafischler / cc-mek-scada Goto Github PK

Utilizing the Lua Lockbox project: https://github.com/somesocks/lua-lockbox
Another option is the pure Lua SHA project: https://github.com/Egor-Skriptunoff/pure_lua_SHA

Network Changes

• Network interface object implementation
• Network integration changes for all devices
• MAC init/config file checks
• Versioned lockbox component
• Send serialized string instead of table as payload, serialize function doesn't guarantee order

Notes on HMAC-MD5 with lua-lockbox

Considerations:
https://crypto.stackexchange.com/questions/39305/is-it-safe-to-send-hmac-and-plaintext-in-the-same-message
https://crypto.stackexchange.com/questions/26510/why-is-hmac-sha1-still-considered-secure
https://en.wikipedia.org/wiki/HMAC#Security

Excerpt from https://datatracker.ietf.org/doc/html/rfc6151:

The attacks on HMAC-MD5 do not seem to indicate a practical
vulnerability when used as a message authentication code.
Considering that the distinguishing-H attack is different from a
distinguishing-R attack, which distinguishes an HMAC from a random
function, the practical impact on HMAC usage as a pseudorandom
function (PRF) such as in a key derivation function is not well
understood.

Therefore, it may not be urgent to remove HMAC-MD5 from the existing
protocols. However, since MD5 must not be used for digital
signatures, for a new protocol design, a ciphersuite with HMAC-MD5
should not be included. Options include HMAC-SHA256 [HMAC]
[HMAC-SHA256] and [AES-CMAC] when AES is more readily available than
a hash function.

Example Test Message (unit statuses to coordinator):

local testmsg = "{1,0,42,3,{5,{{},{boilers={},turbines={},rad_mon={},},{TurbineOnline={false,},AutoControl=false,TurbineTrip={false,},HeatingRateLow={false,},HighStartupRate=false,BoilRateMismatch=false,ManualReactorSCRAM=false,FuelInputRateLow=false,PLCHeartbeat=false,MaxWaterReturnFeed=false,RCSFault=false,PLCOnline=false,RadiationMonitor=1,TurbineOverSpeed={false,},CoolantFeedMismatch=false,BoilerOnline={false,},ReactorTempHigh=false,SteamDumpOpen={1,},RCSFlowLow=false,RadiationWarning=false,WasteLineOcclusion=false,SteamFeedMismatch=false,ReactorSCRAM=false,EmergencyCoolant=1,CoolantLevelLow=false,ReactorHighDeltaT=false,AutoReactorSCRAM=false,WaterLevelLow={},RCPTrip=false,GeneratorTrip={false,},},{1,1,1,1,1,1,1,1,1,1,1,1,},{\"REACTOR OFF-LINE\",\"awaiting connection...\",1,false,true,},},{{},{boilers={},turbines={},rad_mon={},},{TurbineOnline={false,},AutoControl=false,TurbineTrip={false,},HeatingRateLow={false,},HighStartupRate=false,BoilRateMismatch=false,ManualReactorSCRAM=false,FuelInputRateLow=false,PLCHeartbeat=false,MaxWaterReturnFeed=false,RCSFault=false,PLCOnline=false,RadiationMonitor=1,TurbineOverSpeed={false,},CoolantFeedMismatch=false,BoilerOnline={false,},ReactorTempHigh=false,SteamDumpOpen={1,},RCSFlowLow=false,RadiationWarning=false,WasteLineOcclusion=false,SteamFeedMismatch=false,ReactorSCRAM=false,EmergencyCoolant=1,CoolantLevelLow=false,ReactorHighDeltaT=false,AutoReactorSCRAM=false,WaterLevelLow={},RCPTrip=false,GeneratorTrip={false,},},{1,1,1,1,1,1,1,1,1,1,1,1,},{\"REACTOR OFF-LINE\",\"awaiting connection...\",1,false,true,},},{{},{boilers={},turbines={},rad_mon={},},{TurbineOnline={false,},AutoControl=false,TurbineTrip={false,},HeatingRateLow={false,},HighStartupRate=false,BoilRateMismatch=false,ManualReactorSCRAM=false,FuelInputRateLow=false,PLCHeartbeat=false,MaxWaterReturnFeed=false,RCSFault=false,PLCOnline=false,RadiationMonitor=1,TurbineOverSpeed={false,},CoolantFeedMismatch=false,BoilerOnline={false,},ReactorTempHigh=false,SteamDumpOpen={1,},RCSFlowLow=false,RadiationWarning=false,WasteLineOcclusion=false,SteamFeedMismatch=false,ReactorSCRAM=false,EmergencyCoolant=1,CoolantLevelLow=false,ReactorHighDeltaT=false,AutoReactorSCRAM=false,WaterLevelLow={},RCPTrip=false,GeneratorTrip={false,},},{1,1,1,1,1,1,1,1,1,1,1,1,},{\"REACTOR OFF-LINE\",\"awaiting connection...\",1,false,true,},},{{},{boilers={},turbines={},rad_mon={},},{TurbineOnline={false,},AutoControl=false,TurbineTrip={false,},HeatingRateLow={false,},HighStartupRate=false,BoilRateMismatch=false,ManualReactorSCRAM=false,FuelInputRateLow=false,PLCHeartbeat=false,MaxWaterReturnFeed=false,RCSFault=false,PLCOnline=false,RadiationMonitor=1,TurbineOverSpeed={false,},CoolantFeedMismatch=false,BoilerOnline={false,},ReactorTempHigh=false,SteamDumpOpen={1,},RCSFlowLow=false,RadiationWarning=false,WasteLineOcclusion=false,SteamFeedMismatch=false,ReactorSCRAM=false,EmergencyCoolant=1,CoolantLevelLow=false,ReactorHighDeltaT=false,AutoReactorSCRAM=false,WaterLevelLow={},RCPTrip=false,GeneratorTrip={false,},},{1,1,1,1,1,1,1,1,1,1,1,1,},{\"REACTOR OFF-LINE\",\"awaiting connection...\",1,false,true,},},},}"

Testing done on CraftOS-PC on Macbook Air M2:
10000 iterations of HMAC-MD5: 9358ms (0.9358ms average per hmac)
10000 iterations of HMAC-SHA1: 9979ms (0.9979ms average per hmac)
10000 iterations of HMAC-SHA224: 11628ms (1.1628ms average per hmac)
10000 iterations of HMAC-SHA256 11882ms (1.1882ms average per hmac)

Testing done on moderately loaded Minecraft 1.16 Server:
1000 iterations of HMAC-MD5: 2340ms (2.34ms average per hmac)
1000 iterations of HMAC-SHA1: 3351ms (3.351ms average per hmac)
1000 iterations of HMAC-SHA224: 5294ms (5.294ms average per hmac)
1000 iterations of HMAC-SHA256 3493ms (3.493ms average per hmac)

Testing done on minimally loaded Minecraft 1.19 Server:
1000 iterations of HMAC-MD5: 1654ms (1.65ms average per hmac)
1000 iterations of HMAC-SHA1: 1840ms (1.84ms average per hmac)
1000 iterations of HMAC-SHA224: 2077ms (2.08ms average per hmac)
1000 iterations of HMAC-SHA256 2449ms (2.45ms average per hmac)

MD5 or SHA1 it is then. 1.5-3ms for the very large coordinator packets that get sent twice a second should be acceptable.

Pure Lua SHA

Testing done on minimally loaded Minecraft 1.19 Server:
1000 iterations of HMAC-MD5: 2895ms (2.90ms average per hmac)
1000 iterations of HMAC-SHA1: 6992ms (6.99ms average per hmac)

Surprisingly, even though this advertised higher speeds, it yielded worse performance when it came to HMACs at least. One of the runs caused a too long without yielding error as well. lua-lockbox it is then.

The system should monitor induction matrix charge level and slow/stop the reactors as it nears high charge percentage.

• SCRAM at limit
• Hold until threshold before re-enabling to prevent rapid enable/disable
• High charge state to wait in, returning from it would re-init process controllers so this is preferable

PLC crashes when ISS checks occur on a newly disconnected reactor that was not enabled while connected.

Specifically referring to valid sequence numbers.

Terminate exits are caught by PPM, but ISS does not check for nil before comparisons and then crashes anyway.

Handle disconnects and wait for devices to return

Still allow forcing burn rates; user safety will be advised with "High Startup Rate" warning in supervisor/coordinator.

Rename ISS (internal safety system) to RPS (reactor protection system) to shift towards real terminology.

https://en.wikipedia.org/wiki/Reactor_protection_system

Flows of coolant/water/steam should correlate. They may deviate during ramp up, but there should be maximum limits at which point the coordinator should attempt to compensate by slowing the reactor. This could detect coolant line failures early.

Coordinator should Coordinator should provide functionality for the user to request a specific quantity of energy to maintain in induction matrices. It will then attempt to satisfy all input requirements to maintain that charge level.

• Calculate moving averages of charge
• Adjust burn rate to reach target with closed loop control
• Test control loop logic
• Tune gains

Takes almost a full second to fetch all the data for a status packet. Remove some data or conditionally cache certain fields?

Would be able to check that SPS rate is matching necessary process rate. Also can notice if we stop receiving polonium, implying we are no longer processing polonium (night time?).

Listen for and connect to PLCs and store map of reactors and data.

Instead of os.loadAPI()

Run primarily for the ISS without a need for comms with a supervisor.

Only wireless modems should be used for comms, wired modems are for external peripherals. Only wireless modems should be used to initialize comms objects, so there needs to be a function to specifically get those.

Automatic (coordinated) waste processing control.

Support optionally switching to plutonium production during the night when polonium processing is not possible, which would also apply to switching off of antimatter.

• Auto waste control interface
• Coordinated waste control (all units assigned to the same target)
• Day/night balancing option requiring the below task
• Solar neutron activator integration
• SPS integration (basic status)

Auto control will always control all units assigned to the same output. If the user wants some to do one thing and others to do another, that's what manual assignment is for.

• Test MODBUS I/O
• Test RSIO

If a reactor in a group is falling below on burn rate, try to compensate by ramping up other reactors.

This makes sense considering they need to await the actual server thread, but this breaks my event queues until I change them to use the parallel API, so that's what needs to be done.

Reactors should be able to be placed into auto or manual mode. Auto ones will be available for process control.

• Groups can be made to divide up load across multiple auto mode reactors
• Can also be set to use the fewest number of reactors (with priority order)

Examples:
Group A: two reactors (max 10mB/t each)
Group B: two reactors (max 10mB/t each)
Group C: four reactors (max 10mB/t each)

• Set group A to 20 mB/t -> each sets to 10mB/t
• Set group B to balanced reserve mode for group A -> each set to 0mB/t
• Set group C to 20 mB/t -> each sets to 5mB/t

Later setting group A to 30 mB/t now will set group A to 10mB/t each then group B to 5mB/t each.

Primary (implied): used first
Reserve (w/ priority): used if needed

Balanced: split among the group
Sequential: fully utilize the first reactor before starting the next

• Unit Display Interface
• Coordinator Back-end
• Supervisor Back-end

Add close connection type to SCADA_MGMT packet type. Use this to close sessions cleanly without having to wait for the watchdog.

Return errors/faults when PPM accesses fail. This is part of supporting #2 more in depth.

Possibly enforce minimum versions? At least store them all on the supervisors.

Can now use full APIs, 10.0 was incomplete.

This could probably safely be done at around 5mB/sec, maybe faster.

Without this feature, a setpoint of 250mB/t from a setpoint of 50mB/t (for example) would flash boil the water too quick for the boiler/turbine to provide returned coolant before the reactor starts to overheat and take damage. This is known from experience.

Coordinator should provide functionality for the user to simply request a specific target generation rate. It will then attempt to satisfy all input requirements to attain as close to the generation rate as possible.

• Calculate initial expected required burn rates based on turbine blade math
• Adjust to target with closed loop control
• Test control loop logic
• Tune gains
• Make blade mismatch check for generation rate mode only

The system should monitor fuel percentages and ramp down the setpoint until the fuel input rate is net positive.

If we lost modem connection to reactor, continuously retry shutting down the reactor until we reconnect and can confirm shutdown occurred.

PLCs should continuously retry supervisor connection after timeout rather than exit.

Utilize parallel waitForAll to speed up reads.

RTU thread per unit with busy flag, respond with MODBUS TCP error code device busy if in progress.

Need to change how data is stored, and it should only be sent as basic arrays.

Support RTU connections and map to reactor capabilities.

Modem disconnects are not handled correctly.

This bug has occurred on an RTU alpha-v0.2.3. Re-forming the boiler temporarily fixed it, but the problem quickly returned. Re-wiring the modems had no affect.

[Fri Apr 22 10:24:59 2022] [WRN] PPM: lost device boiler mounted to boiler_3
[Fri Apr 22 10:24:59 2022] [DBG] PPM: mount(boiler_3) -> found a boiler
[Fri Apr 22 10:24:59 2022] [WRN] PPM: lost device boiler mounted to boiler_3
[Fri Apr 22 10:24:59 2022] [DBG] PPM: mount(boiler_3) -> found a boiler
[Fri Apr 22 10:24:59 2022] [WRN] PPM: lost device boiler mounted to boiler_3
[Fri Apr 22 10:24:59 2022] [DBG] PPM: mount(boiler_3) -> found a boiler
[Fri Apr 22 10:24:59 2022] [WRN] PPM: lost device boiler mounted to boiler_3
[Fri Apr 22 10:24:59 2022] [DBG] PPM: mount(boiler_3) -> found a boiler
[Fri Apr 22 10:24:59 2022] [WRN] PPM: lost device boiler mounted to boiler_3
[Fri Apr 22 10:24:59 2022] [DBG] PPM: mount(boiler_3) -> found a boiler
[Fri Apr 22 10:24:59 2022] [WRN] PPM: lost device boiler mounted to boiler_3
[Fri Apr 22 10:24:59 2022] [DBG] PPM: mount(boiler_3) -> found a boiler
[Fri Apr 22 10:24:59 2022] [WRN] PPM: lost device boiler mounted to boiler_3
[Fri Apr 22 10:24:59 2022] [DBG] PPM: mount(boiler_3) -> found a boiler
[Fri Apr 22 10:25:00 2022] [WRN] PPM: lost device boiler mounted to boiler_3
[Fri Apr 22 10:25:00 2022] [DBG] PPM: mount(boiler_3) -> found a boiler
[Fri Apr 22 10:25:00 2022] [WRN] PPM: lost device boiler mounted to boiler_3
[Fri Apr 22 10:25:00 2022] [DBG] PPM: mount(boiler_3) -> found a boiler
[Fri Apr 22 10:25:00 2022] [WRN] PPM: lost device boiler mounted to boiler_3
[Fri Apr 22 10:25:00 2022] [DBG] PPM: mount(boiler_3) -> found a boiler
[Fri Apr 22 10:25:00 2022] [WRN] PPM: lost device boiler mounted to boiler_3
[Fri Apr 22 10:25:00 2022] [DBG] PPM: mount(boiler_3) -> found a boiler
[Fri Apr 22 10:25:00 2022] [WRN] PPM: lost device boiler mounted to boiler_3
[Fri Apr 22 10:25:00 2022] [DBG] PPM: mount(boiler_3) -> found a boiler
[Fri Apr 22 10:25:00 2022] [WRN] PPM: lost device boiler mounted to boiler_3
[Fri Apr 22 10:25:00 2022] [DBG] PPM: mount(boiler_3) -> found a boiler
[Fri Apr 22 10:25:00 2022] [WRN] PPM: lost device boiler mounted to boiler_3
[Fri Apr 22 10:25:00 2022] [DBG] PPM: mount(boiler_3) -> found a boiler
[Fri Apr 22 10:25:00 2022] [WRN] PPM: lost device boiler mounted to boiler_3
[Fri Apr 22 10:25:00 2022] [DBG] PPM: mount(boiler_3) -> found a boiler
[Fri Apr 22 10:25:00 2022] [WRN] PPM: lost device boiler mounted to boiler_3
[Fri Apr 22 10:25:00 2022] [DBG] PPM: mount(boiler_3) -> found a boiler
[Fri Apr 22 10:25:00 2022] [WRN] PPM: lost device boiler mounted to boiler_3
[Fri Apr 22 10:25:00 2022] [DBG] PPM: mount(boiler_3) -> found a boiler
[Fri Apr 22 10:25:00 2022] [WRN] PPM: lost device boiler mounted to boiler_3
[Fri Apr 22 10:25:00 2022] [DBG] PPM: mount(boiler_3) -> found a boiler
[Fri Apr 22 10:25:00 2022] [WRN] PPM: lost device boiler mounted to boiler_3
[Fri Apr 22 10:25:00 2022] [DBG] PPM: mount(boiler_3) -> found a boiler
[Fri Apr 22 10:25:00 2022] [WRN] PPM: lost device boiler mounted to boiler_3
[Fri Apr 22 10:25:00 2022] [DBG] PPM: mount(boiler_3) -> found a boiler
[Fri Apr 22 10:25:00 2022] [WRN] PPM: lost device boiler mounted to boiler_3
[Fri Apr 22 10:25:00 2022] [DBG] PPM: mount(boiler_3) -> found a boiler
[Fri Apr 22 10:25:00 2022] [WRN] PPM: lost device boiler mounted to boiler_3
[Fri Apr 22 10:25:00 2022] [DBG] PPM: mount(boiler_3) -> found a boiler
[Fri Apr 22 10:25:00 2022] [WRN] PPM: lost device boiler mounted to boiler_3
[Fri Apr 22 10:25:00 2022] [DBG] PPM: mount(boiler_3) -> found a boiler
[Fri Apr 22 10:25:00 2022] [WRN] PPM: lost device boiler mounted to boiler_3
[Fri Apr 22 10:25:00 2022] [DBG] PPM: mount(boiler_3) -> found a boiler
[Fri Apr 22 10:25:00 2022] [WRN] PPM: lost device boiler mounted to boiler_3
[Fri Apr 22 10:25:00 2022] [DBG] PPM: mount(boiler_3) -> found a boiler
[Fri Apr 22 10:25:00 2022] [WRN] PPM: lost device boiler mounted to boiler_3
[Fri Apr 22 10:25:00 2022] [DBG] PPM: mount(boiler_3) -> found a boiler
[Fri Apr 22 10:25:00 2022] [WRN] PPM: lost device boiler mounted to boiler_3
[Fri Apr 22 10:25:00 2022] [DBG] PPM: mount(boiler_3) -> found a boiler
[Fri Apr 22 10:25:01 2022] [WRN] PPM: lost device boiler mounted to boiler_3
[Fri Apr 22 10:25:01 2022] [DBG] PPM: mount(boiler_3) -> found a boiler

This will help with debugging and software development going forward.