mikastiv / ft_containers-terminator Goto Github PK

When trying to compile the test insert_size in vector, I get an compiler error stating that: "'numeric_limits' is not a member of 'std'".

Reproduce:
bash run_test_files.sh vector insert_size.

Possible solution:
include the header limits.

I think there is a misleading error when testing the upper_bound() and equal_range() methods the STL map segfaults when passing the INT_MAX as an argument to the methods and my container has the same behavior but the tester shows me KO I think this case shouldn't be tested or the result get compared with the STL one

        b = m.upper_bound(std::numeric_limits<int>::max());

        PRINT_BOUND(b, m.end());

        m.insert(NAMESPACE::make_pair(std::numeric_limits<int>::max(), "max"));

        b = m.upper_bound(std::numeric_limits<int>::max());

        PRINT_BOUND(b, m.end());

I suggest

        m.insert(NAMESPACE::make_pair(std::numeric_limits<int>::max(), "max"));

        b = m.upper_bound(std::numeric_limits<int>::max() - 1);

        PRINT_BOUND(b, m.end());

Hello, if you want to add it, there is one more test that concerns the assign_range (and ctor_range) capacity
The input iterator and the random access iterator use different techniques of allocating

The first one (input iterator) uses the push-back method, so, the capacity will double as the size becomes equal to it
The second one (random access iterator) will allocate as far as the range distance

WHAT WILL I ADD?

Use PRINT_CAPACITY instead of CHECK_CAPACITY

It will be more efficient, the tester will return KO if the user has not dealt with this