Comments (7)
miekg
commented on June 3, 2024
I don't think that's a good idea considering label cardinality. If you need
this data you prolly want to get it from your logs
…On Mon, 3 Jun 2019, 16:48 Louis Forite, ***@***.***> wrote:
We would like to segregate our metrics by path such as:
- caddy_http_request_count_total{host, family, proto, *path*}
- caddy_http_request_duration_seconds{host, family, proto, *path*}
- caddy_http_response_latency_seconds{host, family, proto, *path*,
status}
- caddy_http_response_size_bytes{host, family, proto, *path*, status}
- caddy_http_response_status_count_total{host, family, proto, *path*,
status}
If it's fine for you I can open a PR
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#50?email_source=notifications&email_token=AACWIW43JARCNWSQPECFYNDPYU4NRA5CNFSM4HSJMKL2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GXKHPVQ>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AACWIW2NPVDH5HDQCOXJB7TPYU4NRANCNFSM4HSJMKLQ>
.
from caddy-prometheus.
hairyhenderson
commented on June 3, 2024
I was actually also thinking of this a few weeks ago. Our use-case is where we want to make sure that Caddy is serving files within a certain latency, but only from certain paths.
The cardinality is a concern, however the usual way we deal with this with other services is by setting the path value not to the final path, but to the endpoint that handled the request (i.e. the proxy from, or rewrite basepath, etc...).
Also it's probably important to omit the path label for non-matching requests - ones that would result in a 404.
For compatibility, this should definitely be an opt-in feature, not enabled by default.
from caddy-prometheus.
lforite
commented on June 3, 2024
Even for a 404 this information would be useful: you could see which resource resulted in a 404 which might be a useful piece of information.
@miekg what about making it opt-in ?
from caddy-prometheus.
miekg
commented on June 3, 2024
Paths are basically unbounded and as such not applicable for use as a label
value.
…On Tue, 4 Jun 2019, 08:00 Louis Forite, ***@***.***> wrote:
Even for a 404 this information would be useful: you could see which
resource resulted in a 404 which might be a useful piece of information.
@miekg <https://github.com/miekg> what about making it opt-in ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#50?email_source=notifications&email_token=AACWIWYKIFLAQOXCCEPKIX3PYYHHDA5CNFSM4HSJMKL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODW3TUYY#issuecomment-498547299>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AACWIW74I7AXEWK3VJRNNMDPYYHHDANCNFSM4HSJMKLQ>
.
from caddy-prometheus.
lforite
commented on June 3, 2024
you mean size wise ?
from caddy-prometheus.
lforite
commented on June 3, 2024
Probably you refer to: prometheus/client_golang#491 ?
from caddy-prometheus.
hairyhenderson
commented on June 3, 2024
you mean size wise ?
He's referring to cardinality, which is true. Unbounded cardinality can be a bit of an Achilles' heel for Prometheus.
The cardinality could be bounded by setting a static value per endpoint. Not sure about how to actually implement that, though 😉
from caddy-prometheus.
Related Issues (20)
- 404 and errors aren't exported anymore HOT 2
- /metrics returns 404 HOT 3
- Reuse exporter for custom metrics HOT 3
- Status code always responds 0 when using proxy. HOT 1
- publish plugin to new website HOT 1
- Setting status code to rw.Status() side effects other plugins HOT 6
- 429 status not reported from ratelimit middleware HOT 8
- Would it be possible to listen on the same port as Caddy itself? HOT 4
- Provide a Grafana dashboard HOT 5
- redir-ed domain don't show in stats HOT 1
- Export user agent? HOT 4
- "Family" label doesn't work HOT 2
- Record request latency
- Using this plugin with websockets causes a panic HOT 10
- Tricky to add more directives to the proxy block HOT 1
- Change Family tag to understandable values HOT 1
- Restart failed: [prometheus] failed to obtain certificate HOT 1
- Caddy's import path has changed HOT 2
- Caddyext does not exist anymore :)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from caddy-prometheus.