Comments (8)
miekg
commented on June 3, 2024
Are you running that code as middleware in Caddy?
Can you test some some, i.e. does printing the status also say 429?
from caddy-prometheus.
sporkmonger
commented on June 3, 2024
Yup, printing status comes back 429.
from caddy-prometheus.
sporkmonger
commented on June 3, 2024
Is it possible that the middleware chain was short circuited by the rate limit hit and prometheus plugin never gets called?
from caddy-prometheus.
miekg
commented on June 3, 2024
[ Quoting <[email protected]> in "Re: [miekg/caddy-prometheus] 429 st..." ]
Is it possible that the middleware chain was short circuited by the rate limit hit and prometheus plugin never gets called?
depends on the order of our middleware... I've put this one first.
caddyhttp/httpserver/plugin.go seems to have it, using the default, will not
make it work, as "prometheus" is defined near the end.
from caddy-prometheus.
sporkmonger
commented on June 3, 2024
Just to confirm, prometheus should be first?
from caddy-prometheus.
miekg
commented on June 3, 2024
Yes. Early enough to catch all your middleware
…On Aug 1, 2017 4:58 PM, "Bob Aman" ***@***.***> wrote:
Just to confirm, prometheus *should* be first?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#29 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAVkW089ToajcJjnf4a-3LdJEelP2zbqks5sT0sVgaJpZM4OpEO0>
.
from caddy-prometheus.
gonzalop
commented on June 3, 2024
I have a similar issue with 304s. I've tried having prometheus as the first line for the servers to no avail.
from caddy-prometheus.
krichprollsch
commented on June 3, 2024
Hello, I have the same issue too.
As @miekg said, I have fixed it by moving the prometheus declaration into caddyhttp/httpserver/plugin.go before ratelimit and re-building caddy from sources.
What about doing a PR on caddy to move prometheus earlier into the list?
Do you think it's a good idea? I suppose some other users encounter this issue too...
from caddy-prometheus.
Related Issues (20)
- 404 and errors aren't exported anymore HOT 2
- /metrics returns 404 HOT 3
- Reuse exporter for custom metrics HOT 3
- Status code always responds 0 when using proxy. HOT 1
- publish plugin to new website HOT 1
- Setting status code to rw.Status() side effects other plugins HOT 6
- Would it be possible to listen on the same port as Caddy itself? HOT 4
- Provide a Grafana dashboard HOT 5
- redir-ed domain don't show in stats HOT 1
- Export user agent? HOT 4
- "Family" label doesn't work HOT 2
- Record request latency
- Using this plugin with websockets causes a panic HOT 10
- Tricky to add more directives to the proxy block HOT 1
- Change Family tag to understandable values HOT 1
- Restart failed: [prometheus] failed to obtain certificate HOT 1
- Add path label in metrics HOT 7
- Caddy's import path has changed HOT 2
- Caddyext does not exist anymore :)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from caddy-prometheus.