This script task does not run tests on Windows agents:

To repro, change the vmImage to vs2017-win2016 and trigger a build.

I believe this happens because:

• npm is npm.cmd on Windows
• The script task combines npm install and npm test into a single .cmd file and executes it
• When an outer batch file calls an inner batch file (without using call syntax), when the inner batch file returns, the outer batch file exits early
• So, the generated .cmd file exits after the first npm command

You can repo this on any Windows machine by executing a batch file containing:

npm install
npm test

To execute both commands, the call syntax must be used:

call npm install
call npm test

I believe the best fix is to use the Npm task instead of the script task (#3).

I noticed that tasks like this one really should have a condition on then so that they run even if tests fail. Not doing so means you will only get the success results and never the failures.

https://github.com/MicrosoftDocs/pipelines-javascript/blob/master/azure-pipelines.yml#L22

There are important files that Microsoft projects should all have that are not present in this repository. A pull request has been opened to add the missing file(s). When the pr is merged this issue will be closed automatically.

Microsoft teams can learn more about this effort and share feedback within the open source guidance available internally.

Merge this pull request

The ArchiveFiles@2 task in azure-pipelines.yml zips up the whole repository including folders like .git and dev dependencies inside node_modules. This is typically not what you want. What would be the production-quality solution here?

According to documentation,

In the properties of the Shell Script task, use the Browse button for the Script Path to select the path to the deploy.sh script in the build artifact. For example, when you use the nodejs-sample repository to build your app, the location of the script is
$(System.DefaultWorkingDirectory)/nodejs-sample/drop/deploy/deploy.sh

I cant seem to find this the .yaml file or any resources that show how this deploy.sh file/ folder is created. it is also not in the linked artifacts directory.

I would appreciate any pointers on this