Code Monkey home page Code Monkey logo

Comments (18)

vegorovinno avatar vegorovinno commented on May 25, 2024

Remove these lines https://github.com/Microsoft/winsdkfb/blob/develop/winsdkfb/winsdkfb/winsdkfb.Shared/FacebookAccessTokenData.cpp#L161-L164

Someone who added them didn't think ahead at all.

from winsdkfb.

khouzam avatar khouzam commented on May 25, 2024

Thanks a lot for looking into this @vegorovinno,

I'll see to update the nuget package.

from winsdkfb.

kellylawson avatar kellylawson commented on May 25, 2024

@khouzam This is blocking some of my users from using our app - is there an ETA on getting a nuget package update? Just found out about this today, would really like to get it fixed for the users that are unable to login. Thanks for your help!

from winsdkfb.

khouzam avatar khouzam commented on May 25, 2024

I'm working on it this week.

from winsdkfb.

kellylawson avatar kellylawson commented on May 25, 2024

from winsdkfb.

khouzam avatar khouzam commented on May 25, 2024

Hi @kellylawson

Can you try the following nuget package: winsdkfb.0.15.0.zip

If it works out, I'll merge this into master and publish it to nuget.

Thanks for the patience.

from winsdkfb.

jmvillagra avatar jmvillagra commented on May 25, 2024

I'm also having problems logging in, not sure is the same bug, but after logging in if I try to login for the first time I get a error code 4201 (User canceled the Dialog flow).
I tried with this test nuget package

from winsdkfb.

kellylawson avatar kellylawson commented on May 25, 2024

@khouzam Sorry I missed this yesterday! I'll give it a try right now.

from winsdkfb.

kellylawson avatar kellylawson commented on May 25, 2024

@khouzam I still get the same error as well:

winsdkfb-version

fberror

Not sure what the fix was; it appears there's some misinterpretation from the FB oauth redirect response? I'm using the WebView login behavior, not sure if that matters:

            FBResult result = await session.LoginAsync(
                new FBPermissions(new List<string>()),
                SessionLoginBehavior.WebView
                );

from winsdkfb.

khouzam avatar khouzam commented on May 25, 2024

Thanks @kellylawson,

This was my bad. I produced the build off the wrong change. It didn't actually include the fix. I've produced a new nuget package with the actual fix and have verified that I was getting the same 4201 error before the change and that it would succeed after the change. Please try again with the following package. The package is based on the 4f06f13 (which you can confirm with the winsdkfb.githash.txt file in the nuget package) commit which includes the login fix which is commit f214ba1.

Here's the new package: winsdkfb.0.15.0.zip

Sorry for the randomization.

@jmvillagra this seems to be the exact same error.

from winsdkfb.

kellylawson avatar kellylawson commented on May 25, 2024

@khouzam I gave this package a try and get the same error, but it looks a little suspicious as these .nupkg files are exactly the same size. One has a create time stamp on the 4th, and the newer one has a create timestamp yesterday on the 5th. I replaced the newer one in the project twice, and made sure to remove the old file from my system as well... same error.

The file size is 1,978,014 bytes/1,978,368 bytes on disk - can you compare with the package with the fix, perhaps?
filecompare

from winsdkfb.

khouzam avatar khouzam commented on May 25, 2024

Hi @kellylawson,

I tried it again and it looks like this is the right package. The modified date is right, Looking at the contents, it has the right hash value and installing it in our sample project works fine. Can you enable mixed mode debugging in your project and look at the module that is loaded in your process? It should have a version of 0.15.1810.05002

image

Also if you go to your solution folder, there should be packages folder with a winsdkfb.0.15.0 folder under it. Please delete the folder. Nuget caches the packages that you download and since I didn't change the version, it might not have overridden it with the updated package.

from winsdkfb.

kellylawson avatar kellylawson commented on May 25, 2024

Hey @khouzam,

I managed to get the updated dll imported - it looks like you were right, the nupkg was coming from a cache somewhere, and because it was the same version number I ended up just manually copying the new dll out of the .nupkg archive and placing it into my project to debug.

Either way, it works and is ready to publish! Thanks for taking care of that, and thanks to @vegorovinno for posting a suggested fix. Let me know when the new version is published.

from winsdkfb.

jmvillagra avatar jmvillagra commented on May 25, 2024

I'm now having troubles building my solution with this new package:

4>error PRI175 : 0x80073b0f - Processing Resources failed with error : Duplicate Entry.
4>GENERATEPROJECTPRIFILE : error PRI277: 0xdef00532 - Conflicting values for resource ''
========== Rebuild All: 3 succeeded, 1 failed, 0 skipped ==========
I tried cleaning & deleting bin/obj but I can't make it work.

from winsdkfb.

khouzam avatar khouzam commented on May 25, 2024

Hi @jmvillagra

Can you check that all your projects are referencing the same versions of the nuget package?

https://stackoverflow.com/a/51488478 seems to talk about a similar issue.

from winsdkfb.

khouzam avatar khouzam commented on May 25, 2024

Hi,

I've published the updated nuget package on the nuget.org feed. Please try to update your projects.

from winsdkfb.

kellylawson avatar kellylawson commented on May 25, 2024

Works for me - thanks again!

from winsdkfb.

khouzam avatar khouzam commented on May 25, 2024

I'll be closing this issue since it seems to have been addressed.

from winsdkfb.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.