Comments (5)
No worries! I'm glad you got things sorted out.
from windows.ui.composition-win32-samples.
Are you calling Dispose on both the GraphicsCaptureSession and Direct3D11CaptureFramePool each time you capture? Does the memory usage change if you force the GC to run? What else are you doing in your service object?
from windows.ui.composition-win32-samples.
Hey Rob, thanks for responding.
my _screenshotService
is what's called in the repo as BasicSampleApplication
-
Calling StopCapture
does -
public void StopCapture()
{
capture?.Dispose();
brush.Surface = null;
}
Which is calling the disposal of the capture that is doing -
public void Dispose()
{
session?.Dispose();
framePool?.Dispose();
swapChain?.Dispose();
d3dDevice?.Dispose();
}
Profiling my app does show an increase of 78 Direct3D11FramePool
objects in a span of a couple of minutes, so maybe they aren't actually being disposed and I keep getting new frames for every instance of those frame pools?
How would you recommend forcing the GC to kill them?
from windows.ui.composition-win32-samples.
System.GC.Collect will force the garbage collector to run. I wouldn't use it in production code but it can be useful to see if the runtime is just hoarding memory or if you really have a leak.
That application class is not meant to be created multiple times. You are creating a ton of D3D devices each time, I would refactor the code to accept a D3D device instead and reuse the same device across all captures.
Oops, I misread your snippet.
from windows.ui.composition-win32-samples.
I forgot I've added a screenshot capability to the service, where it basically saves the first captured frame into a CpuTexture,
That I (sadly) forgot to add to the dispose method, so every time I started a new capture session I also added a CpuTexture that I didn't dispose of... (therefore using System.GC.Collect didn't release any memory...)
Forgive my mistake, thanks for helping out.
I'll close this issue.
As this was simply a mistake on my part, feel free to delete this issue completely to avoid confusing others.
Cheers
from windows.ui.composition-win32-samples.
Related Issues (20)
- Some samples use `WindowsRuntimeMarshal` class, that is no longer available in .NET 5+ HOT 4
- Cannot use IGraphicsCaptureItemInterop::CreateForWindow with electron apps HOT 6
- This repo is missing important files HOT 4
- How to capture Windows10/11 Virtual Desktop via Windows.Graphics.Capture ? HOT 2
- Accessing screen capture image bytes with MapFlags.DoNotWait for better CPU usage HOT 3
- Can I do successive captures on two different windows HOT 8
- ScreenCapture Sample - write capture stream to disk mp4? HOT 5
- Capture area of a monitor HOT 4
- BSODs on 4 separate Hard Drives HOT 3
- Multiple screen captures in a loop cause explorer.exe and native Windows app to lag? HOT 11
- Capture OnFrame Callback very slow on Win11 23H2 HOT 7
- access_denied in CreateForMonitor in some cases HOT 5
- Cannot catch errors in CreateCaptureItemForWindow HOT 3
- WGC CaptureFrame returns wrong SystemRelativeTime in window capture mode HOT 2
- Cursor may become invisible when recording some fullscreen games using WGC HOT 6
- Frame has issue after change window state (maximize from normal/ normal from maximize/ ...) HOT 1
- ScreenCaptureforHWND sample leaks handles leading to "Out of memory" crash HOT 1
- ScreenCaptureforHWND sample main thread hang HOT 2
- ScreenCaptureforHWND: How to get the byte data of the captured frame? HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from windows.ui.composition-win32-samples.