Code Monkey home page Code Monkey logo

vso-extension-tools's People

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

vso-extension-tools's Issues

`vset package` creates bogus directory structure in extension directory

I have a vss-extension.json in /Users/joao/Desktop/uuid with the following contents:

{
    "id": "uuid",
    "version": "0.1.0",
    "name": "UUID",
    "publisher": "joaomoreno"
}

This is how my tree structure looks like:

➜ tree
.
└── vss-extension.json

0 directories, 1 file

This is how it looks like after running vset package:

➜ vset package
=== Visual Studio Online Extension Tool ===

info:     Begin package creation
info:     - Merge partial manifests
info:     - Merging 1 manifests from the following paths:
info:     -- /Users/joao/Desktop/uuid/vss-extension.json
success:  Merged successfully
info:     - Beginning writing VSIX
info:     -- VSIX written to: /Users/joao/Desktop/uuid/joaomoreno.uuid-0.1.0.vsix
success:  Successfully created VSIX package.
➜ tree
.
├── Users
│   └── joao
│       └── Desktop
│           └──uuid
├── joaomoreno.uuid-0.1.0.vsix
└── vss-extension.json

4 directories, 2 files

It seems to have created the dummy Users/joao/Desktop/uuid structure for no good reason.

package.js doesn't like files without extensions

I'm packing up my vso extension, which includes node_modules, which includes shelljs

debug:    Magic mime type for sod-start-sc/node_modules/vso-task-lib/node_modules/shelljs/bin/shjs is text/x-c++.
debug:    TypeError: Cannot set property 'contentType' of undefined
debug:        at /Users/gavinmogan/.nvm/versions/node/v4.2.1/lib/node_modules/vset/bin/src/scripts/package.js:884:77
debug:        at ChildProcess.exithandler (child_process.js:194:7)
debug:        at emitTwo (events.js:87:13)
debug:        at ChildProcess.emit (events.js:172:7)
debug:        at maybeClose (internal/child_process.js:818:16)
debug:        at Socket.<anonymous> (internal/child_process.js:319:11)
debug:        at emitOne (events.js:77:13)
debug:        at Socket.emit (events.js:169:7)
debug:        at Pipe._onclose (net.js:469:12)

Looks like the code is checking if not the object, then sets a value in the object, which is undefined.

There's another unchecked exception a little further down

                            hitCounts[type].forEach(function (fileName) {

uses overrides directly without checking to see if it exists

I can setup a typescript environment and try to provide better line numbers.

Add editorconfig to support contributions

I went to try to provide a patch and found out some files are spaces, some are tabs, some are 2, some are 4.

My recommendation is to start with editorconfig-tools
find . -type f -name '*.ts' -exec editorconfig-tools infer {} + > .editorconfig

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.