Code Monkey home page Code Monkey logo

Comments (7)

whzx5byb avatar whzx5byb commented on April 30, 2024 1

See #39504 (comment)

That’s because class, let and const don’t create own properties on the global object, instead they create variable bindings on a Declarative Environment Record, so this is the expected behaviour.

If you still want to do this, try this workaround.

declare global {
    namespace globalThis {
        class WorldClass {
            constructor();
            important: number;
        }
        export { WorldClass }
    }
}

const w = new global.WorldClass(); // OK

from typescript.

MartinJohns avatar MartinJohns commented on April 30, 2024

Your "Playground" link does not work and leads to a 404.

from typescript.

jayshah123 avatar jayshah123 commented on April 30, 2024

Your "Playground" link does not work and leads to a 404.

It's a github link as I need more than one file: https://github.com/jayshah123/typescript-declare-global-class-issue

from typescript.

MartinJohns avatar MartinJohns commented on April 30, 2024

And I'm telling you that your link doesn't work, it leads to a 404 page. Perhaps you have set it to private.

from typescript.

jayshah123 avatar jayshah123 commented on April 30, 2024

And I'm telling you that your link doesn't work, it leads to a 404 page. Perhaps you have set it to private.

My bad, made it public

from typescript.

jayshah123 avatar jayshah123 commented on April 30, 2024

Is this a common pattern for globals class declaration - declare interface + declare var,

/**
 * The URL interface represents an object providing static methods used for creating object URLs.
 *
 * [MDN Reference](https://developer.mozilla.org/docs/Web/API/URL)
 */
interface URL {
    hash: string;
    host: string;
    hostname: string;
    href: string;
    toString(): string;
    readonly origin: string;
    password: string;
    pathname: string;
    port: string;
    protocol: string;
    search: string;
    readonly searchParams: URLSearchParams;
    username: string;
    toJSON(): string;
}

declare var URL: {
    prototype: URL;
    new(url: string | URL, base?: string | URL): URL;
    canParse(url: string | URL, base?: string): boolean;
    createObjectURL(obj: Blob | MediaSource): string;
    revokeObjectURL(url: string): void;
};

if the behavior mentioned in the issue description is an expcted one,
should we add this to FAQ?

from typescript.

fatcerberus avatar fatcerberus commented on April 30, 2024

The behavior mentioned matches JS runtime behavior:

<script>
class Foo {}
console.log(Foo);  // [class Foo]
console.log(globalThis.Foo);  // undefined
</script>

I don't think it needs to be documented separately if the types match the runtime reality.

from typescript.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.