Comments (8)
If it works in JavaScript,
tsc
should not complain.
I mean.. the entire concept of TypeScript is to prevent things that work in JavaScript.
from typescript.
https://stackoverflow.com/questions/41750390/what-does-all-legal-javascript-is-legal-typescript-mean
How is that relevant in this specific case? As far as I know, (number | bigint) > (number | bigint)
has no pitfalls: There are no situations where two inputs fail to compare the way one would expect them to. There also isn't a more explicit way to express this comparison.
from typescript.
Normally this is where I say "Ah actually there's a hidden gotcha here" but there really isn't one. JS actually does this right in every case.
from typescript.
@nmain The point of linking that was simply to point out that, in general, "this code works in JS" is not a motivating argument against TS type errors by itself--it doesn't move the needle at all. You need more justification than that.
That being said, I'm very surprised to find out this comparison is allowed, given that from what I recall the spec authors were very careful to ensure mixing bigints and numbers was a runtime error in most other situations. Heck, even +5n
, an explicit conversion, is a runtime error!
from typescript.
If it works in JavaScript, tsc should not complain.
Obligatory link to https://stackoverflow.com/questions/41750390/what-does-all-legal-javascript-is-legal-typescript-mean
from typescript.
The spec explainer goes into detail about the rationale for both comparison operators and unary plus.
from typescript.
The real issue here is that BigInt
does not refer to bigint
as Number
does in the JSDoc type expression. It works fine if you replace it with bigint
.
/**
* @param {Number|bigint} n
*/
function isLessThanFive(n) {
return n < 5;
}
from typescript.
@RyanCavanaugh where's the approximate place in the code where this would need to be changed? Is it something that someone unfamiliar with the codebase is likely to be able to find?
(I mean, it seems simple - find some operator list and add a type to a list of comparable types - but I have no idea how far the rabbit hole might go)
from typescript.
Related Issues (20)
- [ServerErrors][TypeScript] 5.5.0-dev.20240414 HOT 12
- [ServerErrors][JavaScript] 5.5.0-dev.20240414 HOT 12
- TypeScript Fails to Infer Specific Generic Types as Expected HOT 2
- [BUG]: TypeScript throws errors when adding [key: string]: string if other properties are not of type string HOT 2
- Support importing types from a `.mts` file from within a CommonJS file. HOT 7
- `(nullable?.methodOrProperty ?? defaultValue) === defaultValue` should be a type guard HOT 11
- Type refinement on properties no longer refines the whole structure HOT 3
- Import intellisense not working HOT 14
- [TypeScript] 5.4.5 - if(true) {return -1} throws off control-flow analysis HOT 1
- WebGL(2) context methods don't allow null for resource parameters HOT 2
- Interface cannot override predicate return type with boolean HOT 2
- Debug Failure. False expression: Token end is child end
- Modify the issue templates `bug_report.yml` and `feature_request.yml` to improve the quality of further submitted issues HOT 6
- Duplicate diagnostics HOT 2
- `const enum` references in the body of nodes with grammar errors are not inlined
- `static` methods can access `this.constructor` without complaints and compiles correctly, but a runtime error shows up HOT 13
- ModuleResolution Node16/NodeNext fails without extension starting on 5.5.0-dev.20240413 HOT 5
- Assigning a @type to an async function emits an error HOT 1
- Type predicate covariant comparison is unsound HOT 1
- Assignability to `asserts` type predicate is not checked HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from typescript.