Code Monkey home page Code Monkey logo

Comments (6)

Andarist avatar Andarist commented on April 27, 2024 1

This is likely the same thing that I've raised here. zod's objects outputs (see here) are typed using their addQuestionMarks utility which is defined like this:

  type requiredKeys<T extends object> = {
    [k in keyof T]: undefined extends T[k] ? never : k;
  }[keyof T];

  export type addQuestionMarks<
    T extends object,
    R extends keyof T = requiredKeys<T>
  > = Pick<Required<T>, R> & Partial<T>;

So their definitions always contain a possibility of an optional property. This type is not generic though and the fact that its origin is in this mapped type is something that the user doesn't really ever see so it's a surprising behavior.

from typescript.

Andarist avatar Andarist commented on April 27, 2024 1

@RyanCavanaugh I could try to boil down Zod's case to the bare minimum but from what I understand the underlying root cause for this in Zod is the same as in the comment I've quoted. Copying the mentioned code there (TS playground):

type Obj = {
  a: string;
  b: number;
};

type Obj2 = {
  b: number;
  c: boolean;
};

declare const mapped: {
  [K in keyof (Partial<Obj> & Required<Obj2>)]: number;
};

// displays the same way as `resolved` below!
mapped;
// ^? const mapped: { a?: number | undefined; b: number; c: number; }

const accessMapped = <K extends keyof Obj2>(key: K) => mapped[key].toString(); // error, a mystery to the user

declare const resolved: { a?: number | undefined; b: number; c: number };

const accessResolved = <K extends keyof Obj2>(key: K) => resolved[key].toString(); // since this is OK

from typescript.

RyanCavanaugh avatar RyanCavanaugh commented on April 27, 2024

We'd need a standalone repro (i.e. one that doesn't import anything, certainly not something as complex as zod) here to investigate further

from typescript.

RyanCavanaugh avatar RyanCavanaugh commented on April 27, 2024

Above example bisects to the same PR, to be clear

from typescript.

MichaelMitchell-at avatar MichaelMitchell-at commented on April 27, 2024

@Andarist beat me to it, but I reduced it down to this, which I think more strongly shows that something is wrong

type EmptyObject = {[K in never]?: never};  // This is just `{}` ?

type BadData = { id: string, prop: string } & EmptyObject;

function badExample<K extends keyof BadData>(data: Pick<Pick<BadData, K | 'id'>, K>): Pick<BadData, K> {
    return data;
    //     ^^^^Same error
}

from typescript.

ahejlsberg avatar ahejlsberg commented on April 27, 2024

Even simpler repro:

type Foo = {
    prop: string;
}

function test<K extends keyof Foo>(obj: Pick<Required<Foo> & Partial<Foo>, K>, key: K) {
    obj[key].length;  // Error: Object is possibly 'undefined'
}

from typescript.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.