Comments (6)
This is likely the same thing that I've raised here. zod
's objects outputs (see here) are typed using their addQuestionMarks
utility which is defined like this:
type requiredKeys<T extends object> = {
[k in keyof T]: undefined extends T[k] ? never : k;
}[keyof T];
export type addQuestionMarks<
T extends object,
R extends keyof T = requiredKeys<T>
> = Pick<Required<T>, R> & Partial<T>;
So their definitions always contain a possibility of an optional property. This type is not generic though and the fact that its origin is in this mapped type is something that the user doesn't really ever see so it's a surprising behavior.
from typescript.
@RyanCavanaugh I could try to boil down Zod's case to the bare minimum but from what I understand the underlying root cause for this in Zod is the same as in the comment I've quoted. Copying the mentioned code there (TS playground):
type Obj = {
a: string;
b: number;
};
type Obj2 = {
b: number;
c: boolean;
};
declare const mapped: {
[K in keyof (Partial<Obj> & Required<Obj2>)]: number;
};
// displays the same way as `resolved` below!
mapped;
// ^? const mapped: { a?: number | undefined; b: number; c: number; }
const accessMapped = <K extends keyof Obj2>(key: K) => mapped[key].toString(); // error, a mystery to the user
declare const resolved: { a?: number | undefined; b: number; c: number };
const accessResolved = <K extends keyof Obj2>(key: K) => resolved[key].toString(); // since this is OK
from typescript.
We'd need a standalone repro (i.e. one that doesn't import anything, certainly not something as complex as zod) here to investigate further
from typescript.
Above example bisects to the same PR, to be clear
from typescript.
@Andarist beat me to it, but I reduced it down to this, which I think more strongly shows that something is wrong
type EmptyObject = {[K in never]?: never}; // This is just `{}` ?
type BadData = { id: string, prop: string } & EmptyObject;
function badExample<K extends keyof BadData>(data: Pick<Pick<BadData, K | 'id'>, K>): Pick<BadData, K> {
return data;
// ^^^^Same error
}
from typescript.
Even simpler repro:
type Foo = {
prop: string;
}
function test<K extends keyof Foo>(obj: Pick<Required<Foo> & Partial<Foo>, K>, key: K) {
obj[key].length; // Error: Object is possibly 'undefined'
}
from typescript.
Related Issues (20)
- VSCode TypeScript extension writes tracing to the wrong directory on Mac OS HOT 1
- computed property name in an interface error when using `[]` already HOT 3
- Proposal: Type-side `instanceof` keyword and functionality HOT 8
- tsserver.js CPU/Memory Spike HOT 3
- [NewErrors] 5.5.0-dev.20240414 vs 5.4.5 HOT 30
- [ServerErrors][TypeScript] 5.5.0-dev.20240414 HOT 12
- [ServerErrors][JavaScript] 5.5.0-dev.20240414 HOT 12
- TypeScript Fails to Infer Specific Generic Types as Expected HOT 2
- [BUG]: TypeScript throws errors when adding [key: string]: string if other properties are not of type string HOT 2
- Support importing types from a `.mts` file from within a CommonJS file. HOT 7
- `(nullable?.methodOrProperty ?? defaultValue) === defaultValue` should be a type guard HOT 11
- Type refinement on properties no longer refines the whole structure HOT 3
- Import intellisense not working HOT 14
- [TypeScript] 5.4.5 - if(true) {return -1} throws off control-flow analysis HOT 1
- WebGL(2) context methods don't allow null for resource parameters HOT 2
- Interface cannot override predicate return type with boolean HOT 2
- Debug Failure. False expression: Token end is child end
- Modify the issue templates `bug_report.yml` and `feature_request.yml` to improve the quality of further submitted issues HOT 6
- Duplicate diagnostics HOT 2
- `const enum` references in the body of nodes with grammar errors are not inlined
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from typescript.