microsoft / tailwindtraders-website Goto Github PK

We should only reference the AKS hosted-backend if a User wants to build their own. Remove references to using the MSFT-hosted backend.

Is the current version of node in the staging and prod yml in the .github/workflows dir correct?

There's a hard-coded setting in the docker-compose.override.yml file which is setting an environment variable which the app appears to need. Suggest using .env or similar. This URL is also in AppSettings.

Right now the docker-compose.yml file doesn't have any setting for ports which means, by default, the site will run on port 80. This doesn't work very well for many dev environments.

I would suggest setting the ports specifically, and instructing people in the README to set ports: 3000:80 so the site works as intended.

Looks liketailwindtraders/web:latest hasn't been pushed to Dockerhub which makes the deploy button not work. Code is here:
https://github.com/Microsoft/TailwindTraders-Website/blob/master/Deploy/deployment.json#L21

Fixing it likely means a push to docker hub.

When running the TailwindTraders.Website/Deploy/DeployWebAKS.ps1 script, it fails with the message:

Deploying web chart
Error: unknown flag: --email

It appears that the email variable on line 148 is incorrect in the call:

--set acsConnectionString=$acsConnectionString --email=$email

It does not have a "--set" and also uses the $email variable and not the $acsEmail variable

In the "Build and Push the docker image" section of the README, it mentions setting the following environment variable:

REPOSITORY: Must be the login server of the ACR where Backend is installed.

However, the intended docker-compose file does not use a variable named REPOSITORY it instead uses one named REGISTRY

See: https://github.com/microsoft/TailwindTraders-Website/blob/master/Source/docker-compose.yml

Suggestion is to consolidate to one of these names and update the documentation accordingly

One of the primary uses of .env files is to use Environment variables instead of hard-coding things. Checking in these files defeats the purpose. I would recommend adding instructions to the README which tells the user how to set environment variables and/or to create a .env file.

https://github.com/Microsoft/TailwindTraders-Website/blob/97ee364e063e16acce35d5bf48bff341812cc57d/Source/.env#L10

I'm getting an error when I try to auto deploy the solution in Standalone mode. I'm getting The specified app service plan was not found. error. Here is the complete error for you to trace.
{ "telemetryId": "b3545cfb-b90a-49f9-9477-5e85dce6d6f1", "bladeInstanceId": "Blade_ea0851e6347d49e3bb5bd70df9efbe47_0_0", "galleryItemId": "Microsoft.Template", "createBlade": "DeployToAzure", "code": "InvalidTemplateDeployment", "message": "The template deployment 'Microsoft.Template' is not valid according to the validation procedure. The tracking id is '20572e19-7e91-40a1-96e1-85e527ee214b'. See inner errors for details.", "details": [ { "code": "ValidationForResourceFailed", "message": "Validation failed for a resource. Check 'Error.Details[0]' for more information.", "details": [ { "code": "ServerFarmNotFound", "message": "The specified app service plan was not found." } ] } ] }

If I understand correctly, this is the client for the server backend, which is (functionally) the shopping cart. Unfortunately the setting below:

https://github.com/Microsoft/TailwindTraders-Website/blob/97ee364e063e16acce35d5bf48bff341812cc57d/Deploy/deployment.json#L34

Hard-codes the client's email address on the server, which means that a single deployment has only one possible user. This goes against the idea of a shopping cart, which should allow for multiple users.

The setting below will deploy Cosmos DB for the customer when they deploy this application:

https://github.com/Microsoft/TailwindTraders-Website/blob/97ee364e063e16acce35d5bf48bff341812cc57d/Deploy/deployment.json#L44

Given that this is the client application built with React, Cosmos DB is not required (unless I misunderstand something). This can result in customers receving unwanted charges.

ARG runtimeTag=3.0
ARG image=mcr.microsoft.com/dotnet/core/aspnet
ARG sdkImage=mcr.microsoft.com/dotnet/core/sdk

unless there is a pinned SDK then 3.x should build anything.

works when i set sdk and runtime to 2.1

essentially work done between 08-31-2019 till now was done without build tests?

Microsoft (R) Build Engine version 16.3.2+e481bbf88 for .NET Core
Copyright (C) Microsoft Corporation. All rights reserved.
  Restore completed in 46.06 ms for /app/Tailwind.Traders.Web.csproj.
  It was not possible to find any compatible framework version
  The specified framework 'Microsoft.NETCore.App', version '2.0.7' was not found.
    - The following frameworks were found:
        3.0.3 at [/usr/share/dotnet/shared/Microsoft.NETCore.App]
  You can resolve the problem by installing the specified framework and/or SDK.
  The .NET Core frameworks can be found at:
    - https://aka.ms/dotnet-download
/root/.nuget/packages/microsoft.aspnetcore.razor.design/2.1.2/build/netstandard2.0/Microsoft.AspNetCore.Razor.Design.CodeGeneration.targets(69,5): error : rzc discover exited with code 150. [/app/Tailwind.Traders.Web.csproj]
Build FAILED.
/root/.nuget/packages/microsoft.aspnetcore.razor.design/2.1.2/build/netstandard2.0/Microsoft.AspNetCore.Razor.Design.CodeGeneration.targets(69,5): error : rzc discover exited with code 150. [/app/Tailwind.Traders.Web.csproj]
    0 Warning(s)
    1 Error(s)
Time Elapsed 00:00:24.59
The command '/bin/sh -c dotnet build' returned a non-zero code: 1
2020/02/26 16:30:24 Container failed during run: build. No retries remaining.
failed to run step ID: build: exit status 1
Run ID: ca5 failed after 4m9s. Error: failed during run, err: exit status 1
Run failed

Is the node version correct in workflows?

When deploying the web portion the readme says:

When you deploy this website to Azure you can define the Backend you want to use in case you have deploy your own backend. By defaults it is configured the public Backend environment provided by Microsoft.

Im having an issue finding documentation or guidance on how exactly you connect the website to the backend. I have both successfully deployed just need specifics on how to connect them.

When opening the site my browser shows the following warning :
your connection to side is not secure.
here's a screen shot :

🌇🌆#WORKING_ALL_DAY🥱😓
Don't guarantee a brighter future....
The right option is investing or trading..
✅ #INVESTMENT is one great option in levicryptotrade.com where you can now invest in various #currencies and #stockmarkets and other fundamental organisation/Companies.
✅ #TRADE is another great option in levicryptotrade.com where you can now buy and sell cryptocurrency and other valuable stocks that can be transported..!
Why not sign-up and become an investor in #LEVI_CRYPTOTRADE_INVESTMENT
#MAKE_MONEY_ONLINE
$3000 each day
$20000 each week
$80000 each month.

The current code on master doesn't build with regular web app workflow for GitHub: https://github.com/microsoft/TailwindTraders-Website/runs/559304897?check_suite_focus=true

Create a Feedback form where users can request a MSFT hosted backend for demo purposes. This does not guarantee it being provided, but gives folks the ability to get one of needed reasonably.

Currently the Deploy README states:

Note: Currently https is not supported. Please use http when browsing the web.

I understand this was done for demo purposes, however Azure provides HTTPS for free in its App Services and this is something we should be leveraging - even for a demo.