I think the file containers.json in the config directory is missing from the repositor

Missing config/containers.json about opensource-management-portal HOT 3 CLOSED

microsoft commented on May 12, 2024

Missing config/containers.json

from opensource-management-portal.

Comments (3)

jeffwilcox commented on May 12, 2024

Interesting... we don't have a containers.json on our end... is there an exception/stack trace you can share?

from opensource-management-portal.

RobCannon commented on May 12, 2024

The following code will fail, from middleware/passport-config.js on line 84. The config.containers element is undefined, unless that file is present.

 let aadStrategy = new OIDCStrategy({
    redirectUrl: config.activeDirectory.redirectUrl,
    allowHttpForRedirectUrl: config.containers.docker || config.webServer.allowHttp,
    realm: config.activeDirectory.tenantId,
    clientID: config.activeDirectory.clientId,
    clientSecret: config.activeDirectory.clientSecret,
    oidcIssuer: config.activeDirectory.issuer,
    identityMetadata: 'https://login.microsoftonline.com/' + config.activeDirectory.tenantId + '/.well-known/openid-configuration',
    responseType: 'id_token code',
    responseMode: 'form_post',
    validateIssuer: true,
  }, activeDirectorySubset);

Further, I see where that is used to make HTTP allowable, which is useful since I making this work from a container where HTTPS termination will take place on the load balancer (code from middleware/index.js).

  if (!initializationError) {
    if (!web) {
      /* No web routes */
    } else if (config.containers && config.containers.deployment) {
      console.log('Container deployment: HTTP: listening, HSTS: on');
      app.use(require('./hsts'));
    } else if (config.containers && config.containers.docker) {
      console.log('Docker image: HTTP: listening, HSTS: off');
    } else if (config.webServer.allowHttp) {
      console.warn('WARNING: Development mode (DEBUG_ALLOW_HTTP): HTTP: listening, HSTS: off');
    } else {
      app.use(require('./sslify'));
      app.use(require('./hsts'));
    }

from opensource-management-portal.

jeffwilcox commented on May 12, 2024

Found the files; they were added in a refactor for Docker support internally in the past.

#75

This PR contains the file/s if you need access now.

from opensource-management-portal.

Related Issues (20)

Recommend Projects