Code Monkey home page Code Monkey logo

Comments (7)

Shegox avatar Shegox commented on May 23, 2024 1

What we/I do is to leverage the /unlink API endpoint. We have an external script, which gets the list of all users from the opensource-portal daily, checks them against our internal user directory, and then if they are not found in our internal user directory unlinks them. Unlinking causes the portal to remove them from all organizations and that works quite well.

The advantage of the external script (vs. e.g. something built-in) is in my opinion that we can manage some special cases and special user directories.

from opensource-management-portal.

jeffwilcox avatar jeffwilcox commented on May 23, 2024 1

@brugidou that's a good point... way too many things are deeply coupled right now. We once had a version working with GSuite and other tech to prove it could be decoupled, but it's not pretty. Open to ideas to abstract out or fix some of that.

I doubt it's really required, but might be used to find e-mail address details or managers or something.

Internally we have another job that helps us find the manager for a former employee, or look it up in a cache of last-known-manager, for example... probably worth us removing from the generic implementation.

from opensource-management-portal.

jeffwilcox avatar jeffwilcox commented on May 23, 2024

We have something very similar... let me see if the script is part of the open source files or not. Some of the more company-specific things are quite hacky.

We use two approaches:

  1. Most-aggressive, we have a company-specific Azure Data Explorer / Kusto query that provides us a very strong confidence that someone has left the company. An hourly job uses this data joined with the link data to then use the 'external' unlink API to remove those users.
  2. A cronjob compares all linked users with the Microsoft Graph, and if the entries by AAD ID 404 a few times consecutively, we remove them.

My bet is #2 is also a little hacky... we had a few instances years ago where we aggressively unlinked users.

from opensource-management-portal.

jeffwilcox avatar jeffwilcox commented on May 23, 2024

I think given that I think we definitely use #1 as the primary approach.

We also use SAML single sign-on for our GitHub orgs in the enterprise, and so have some additional protections in place, since former employees will not be able to SAML in.

Open to ideas to make this more robust or usable.

from opensource-management-portal.

brugidou avatar brugidou commented on May 23, 2024

Hey, thanks for all your answers! it seems that the refreshUsernames job also calls terminateLinkAndMemberships I may try it but it will require me to get the Microsoft Graph provider to work.

from opensource-management-portal.

github-actions avatar github-actions commented on May 23, 2024

This issue has been identified as stale because it has gone 30 days with no activity.
The issue will be closed in 10 days. If this is incorrect, simply comment on the issue, or remove the stale label.

from opensource-management-portal.

jeffwilcox avatar jeffwilcox commented on May 23, 2024

Closing this issue for now;

While strongly coupled to Microsoft graph, the refreshUsernames job + terminateLinkAndMemberships is our recommendation for the time being.

from opensource-management-portal.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.