need readable.on('error', ...), otherwise current process will cash when gzip is used and response data is corrupted

let headers = { 'Accept-Encoding': 'gzip, deflate' };
let request = require('request-light');

setInterval(() => {
  console.log('process running..');
}, 2000);

request.xhr({ url: 'http://json.schemastore.org/tsconfig', followRedirects: 5, headers: headers })
  .then(res => {
    console.log('res', res);
  })
  .catch(err => {
    console.error('err');
  });

node xhr-test.js 
events.js:193
      throw er; // Unhandled 'error' event
      ^

Error: incorrect data check
    at Zlib.zlibOnError [as onerror] (zlib.js:133:17)

This extension is recommended by an extension authoring docs page, so I'm assuming it's ready for production use. However there's no docs anywhere, I couldn't even find what to import from the package.

After I started using request-light instead of the http module to query Chrome for its debug targets, several users on Windows reported getting HTTP errors in this issue https://github.com/Microsoft/vscode-chrome-debug/issues/237. They reported getting 504, 403, and 401 where previously it had been working for them, and they could open the url in a browser.

In this case my code looks like this: https://github.com/Microsoft/vscode-chrome-debug-core/blob/v2.0.2/src/utils.ts#L222 which is basically copied from where vscode-node-debug uses it to download sourcemaps. Below on line 240 is the original code, and when I switched back to that, it worked again. It's very simple, the url was something like http://127.0.0.1:9222/json. I was never able to repro it. Looking at what request-light does, it looks like it should behave the same as the basic http.get. Any idea why this would happen?

Hi, can cancellation support be added, either with AbortController or even better, with vs code style cancellation tokens?

We have some pretty awesome security software that does this man-in-the-middle-attack TLS interception where it decrypts and re-encrypts all TLS traffic.

For Node apps, I've been able to add the environment variable NODE_EXTRA_CA_CERTS and point it to the security software certificate.

It doesn't seem that this obeys that construct, or perhaps the environment in VS Code extensions isn't seeing that value propagated down? I'm encountering issues while trying to use the Azure Pipelines Language Server that uses this library. It pretty consistently issues a message like: "Error: Unable to get local issuer certificate" and that generally points at this MitM thing.

There are important files that Microsoft projects should all have that are not present in this repository. A pull request has been opened to add the missing file(s). When the pr is merged this issue will be closed automatically.

Microsoft teams can learn more about this effort and share feedback within the open source guidance available internally.

Merge this pull request

I work on several Azure extensions for VS Code (For example https://github.com/Microsoft/vscode-azurefunctions). We're trying to work with proxies and I found this package. The README is a little lacking haha so I had a few questions:

1. Is this package ready for use and in a reliable state?
2. Can most extensions ignore configure? It seems like getSystemProxyURI would configure for us
3. Any chance you could export getProxyAgent? Most of the time we go through an Azure ServiceClient instead of making the request directly. Even though we're not making the request, we can still pass in requestOptions to the constructor, which is where getting just the agent would come in handy.

Overview

The library takes provided proxy url or use system configured proxy in environment variable. However, proxies don't work for internal resources and sending request to e.g. localhost or other internal corporate resources fails, depending on proxy configuration.

To do

• Change reading system proxy settings to include NO_PROXY variable https://github.com/microsoft/node-request-light/blob/main/src/node/main.ts#L268-L272
• If requested resource is in NO_PROXY list, don't use proxy agent

It seems that the response is always given as data.join('') in node, but when dealing with binary data, the original data Buffers are needed (to then write them to a stream created by fs.createWriteStream).