Comments (3)
Never happened to me. Interesting how we are finding bugs in 40+ years' games :)!
The time-out is a good idea.
from jericho.
Thanks, I currently use a timeout to filter out the actions that will cause a hang.
from jericho.
Thank you for the bug report. After checking out an older version of Jericho (3.0.5) I can replicate the issue as described. Digging further, the get_valid_actions() call is getting stuck on the action "drop all down sack."
Examining the inventory before the hang:
"You are carrying:\n A bird's nest\n The bird's nest contains:\n A broken jewel-encrusted egg\n The broken jewel-encrusted egg contains:\n A brown sack\n\n"
So we have 3 containers: Nest > Egg > Sack and we're asking to put everything into the sack, including the nest and egg. Zork has trouble handling this type of container switching.
Other buggy behaviors starting from the "put sack in egg" state is to "put egg in sack" - in this case it doesn't hang but if you examine the inventory afterwards "You are carrying:\n A bird's nest" (the egg and sack have completely disappeared). Similarly if we "put nest in sack", the resulting state is 'You are empty-handed.'
It's hard to address the root of the issue, which would require better containership programming in Zork. But there might be a couple workarounds:
- Implement a timeout on valid action search so as to prevent a full hang. (Maybe this isn't too hard if valid action search is already being performed in separate threads.)
- Manually disallow actions that put containers inside of each other. Or equivalently write zork-specific post-step routines to flatten any stacked containers.
@MarcCote curious if you had encountered this issue as well?
from jericho.
Related Issues (20)
- Null deference HOT 1
- Running tests HOT 1
- Windows support HOT 1
- Verify quality of valid action detection HOT 3
- Compilation errors on MacOS Catalina HOT 8
- Getting all the textual description (observations) HOT 6
- Install Jericho on MacOS HOT 5
- Getting the same walkthrough from .get_walkthrough() regardless of seed number HOT 4
- Tracking Incomplete Walkthroughs for Supported Games HOT 1
- linker issue: multiple definition of - first defined here HOT 4
- 'load_bindings()' and action generation grammar parsing error HOT 3
- Score underflow in some games with negative rewards
- Few questions on using Jericho > 3.0.0 HOT 3
- is there a way to see what the engine parses a command as? HOT 4
- How to get possible actions at each step? HOT 4
- Max score not achieved with walkthrough HOT 4
- Dictionary errors on MacOS Monterey HOT 14
- games stuck at certain steps (location ids) HOT 6
- This repo is missing important files
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jericho.