microsoft / innereye-dicom-rt Goto Github PK

Currently we are uploading to test.pypi on tag release, this means that we break subsequent PRs because there is a newest version than the test versions

Currently the test-pypi-pkg job in defined build-test-pr.yml does not run when tagging the repo, which is exactly when it should be run.

In setup.py the dotnetcore2 version is not pinned. This means that the incorrect version (i.e. not 2.1.0) may be installed into any environment using this package without complaint, but any calls to this library will subsequently fail.

When viewing segmentation results in RayStation, the displayed time is about 1h off. This could mean either that the time encoded by IE-DicomRT is not correctly localized, or that RayStation is not displaying timezone info correctly.
We should go through the code here and ensure that IE-DicomRT is correctly storing its processing time in UTC.

Discussed in microsoft/InnerEye-DeepLearning#687

python InnerEye/Scripts/submit_for_inference.py --image_file /home/xxxx/datasets/inference_dicom/patS1102.zip --model_id LungExample:1 --download_folder /home/xxxx/source/2022/download/ --use_dicom true

AB#5453

reported by @furtheraway: Varian's eclipse software can't read some DICOM files output by InnerEye.

Pre-processing the files with Dicom+ helps.

This package is currently running on unsupported versions of .netcore and fo-dicom. These should be upgraded to the latest versions.

There is a nest of problems involved with upgraded the .netcore version as the dotnetcore2 python package seems unhappy with using .netcore 3.1 for some reason!