microsoft / edge-diagnostics-adapter Goto Github PK

Runtime.evaluate("alert('hello')") returns

{"wasThrown":false,"result":{"objectId":null,"type":"undefined","description":""}}}

Per http://writingexplained.org/adapter-vs-adaptor-difference

1. Rename binary to EdgeDiagnosticsAdapter.exe

Hmm, I don't seem to be able to make it work, while the HTTP API works I cannot connect to the WebSocket. Here's what I tried:

1. start Edge;
2. start EdgeDiagnosticsAdapter.exe:

Edge Diagnostics Adapter
Could not set ACL to allow access to IE EPM or Edge.
Error Code: 1332
You can set the ACL manually by adding Read & Execute permissions for 'All APPLICATION PACAKGES' to each dll.
Proxy server listening on port 9222...

1. start chrome-repl and EdgeDiagnosticsAdapter.exe prints:

DEBUG MESSAGE: Attempting to attach to 64 bit tab
Connection rejected for: /devtools/page/E8A36086-8AFC-4300-AC94-8322FB2DC812
[2016-04-24 20:01:41] [error] Handshake ended with HTTP error: 400

I'm trying this in a (64 bit) VM. I get similar results with a 32 bit laptop, the difference is that here I don't get the DEBUG MESSAGE: Attempting to attach to 64 bit tab message.

In order to have source maps working in VS Code and other clients, we need to detect the source map in a given file, and expose the sourceMapURL property on the scriptParsed event.

In order to keep the adaptor minimal we should get of the chrome launching logic, as their devtools should be served from the cloud instead of from a Chrome instance.

Instead it doing something with packagedebug settings.

Edge Diagnostics Adapter
Proxy server listening on port 9222...
Client connection accepted for: /devtools/page/72C7201E-AB65-40C7-97BD-8FC2723D19DD as: 001C0B3A
Failed to CoCreateInstance of CLSID_PackageDebugSettings.
HR Code: -2147221008
Failed to CoCreateInstance of CLSID_PackageDebugSettings.

Just submitted the binaries in https://github.com/Microsoft/edge-diagnostics-adapter/releases/tag/v0.6.0-unsigned for signing so people don't need to enable testsigning.

Once it's done I'll publish a new release in npm.

Steps:

1. Install vscode-edge-debug
2. Start Edge adapter
3. Try to connect VS Code

Windows version: 10.0.15063 Build 15063

Like Target.create from Chrome's protocol - it also supports a GET /json/new

If not, how easy would it be for me to add that?

This means if I am using chrome / VSCode with debug protocol from another machine, then it doesn't work.

I think @molant mentioned some tricky things regarding signing.... but it'd be awesome to have a new release published on NPM when ya'll get a chance. :)

 1>ScriptEngineHost.cpp(33): error C2660: 'JsCreateRuntime': function does not take 3 arguments [E:\personal\edge-diagnostics-adapter\native\Proxy\Proxy.vcxproj]
 1>ScriptEngineHost.cpp(36): error C2660: 'JsCreateContext': function does not take 2 arguments [E:\personal\edge-diagnostics-adapter\native\Proxy\Proxy.vcxproj]
 1>ScriptEngineHost.cpp(397): error C2660: 'JsStartDebugging': function does not take 0 arguments [E:\personal\edge-diagnostics-adapter\native\Proxy\Proxy.vcxproj]

[13:41:19] MSBuild failed with code 1!

Add support of setScriptSource, to enable projects like https://github.com/amokjs/amok to work with Edge.

Running gulp build

Log:

[16:54:50] Finished 'buildnativeprojects' after 9.59 s
[16:54:50] Starting 'buildnativeaddon'...
[16:54:55] Building the projects in this solution one at a time. To enable parallel build, please add the "/m" switch.
[16:54:55]   stdafx.cpp
[16:54:55]   EdgeFunctions.cpp
[16:54:55]   MessageReceiver.cpp
[16:54:55]   win_delay_load_hook.cc
[16:54:55] c:\users\kennau\appdata\local\lxss\root\edge-diagnostics-adapter\native\addon\MessageReceiver.h(40): error C2653: 'AsyncProgressWorker': is not a class or namespace name (compiling source file ..\MessageReceiver.cpp) [C:\Users\kennau\AppData\Local\lxss\root\edge-diagnostics-adapter\native\Addon\build\Addon.vcxproj]
[16:54:55] c:\users\kennau\appdata\local\lxss\root\edge-diagnostics-adapter\native\addon\MessageReceiver.h(40): error C2653: 'AsyncProgressWorker': is not a class or namespace name (compiling source file ..\EdgeFunctions.cpp) [C:\Users\kennau\AppData\Local\lxss\root\edge-diagnostics-adapter\native\Addon\build\Addon.vcxproj]
[16:54:55] ..\EdgeFunctions.cpp(391): warning C4244: 'initializing': conversion from 'double' to 'int', possible loss of data [C:\Users\kennau\AppData\Local\lxss\root\edge-diagnostics-adapter\native\Addon\build\Addon.vcxproj]

Example: -port 6000

Saw the output of #18 and started digging around a little bit, I'm seeing null being used for a lot of optional parameters.

For example, subtypes are marked as null in https://github.com/Microsoft/edge-diagnostics-adapter/blob/master/EdgeWebKitImpl/debugger.ts#L320-L323

If there is no subtype, then the property should just not be set?

There are important files that Microsoft projects should all have that are not present in this repository. A pull request has been opened to add the missing file(s). When the pr is merged this issue will be closed automatically.

Microsoft teams can learn more about this effort and share feedback within the open source guidance available internally.

Merge this pull request

Just opening this issue for reference and keeping work on that :)

I've tried to build the project using gulp build --x64 with a Windows 10 having only VS2017 installed.
In the VS2017 installer the C++ workload ("Desktop Development with C++") was installed with both C++ toolsets: 141 (VS2017) and 140 (VS2015).

Using gulp build --x64 failed due to not founding msbuild. This can be solved by editing gulpfile.js and forcing toolsVersion to 15 in the msbuild call.
But node-gyp complains about compiling the addin node later.

Tried several things with no luck.

Finally I installed "Visual C++ Tools for VS2015" (http://landinghub.visualstudio.com/visual-cpp-build-tools) and reverting the toolsVersion to 14 in the gulpfile.js.
Some errors happening complaining about the file Microsoft.Cpp.Defaults.props. Finally need to set these two environment variables:

set VCTargetsPath=C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\v140
set GYP_MSVS_VERSION=2015

This allowed the compilation of the project using Visual C++ 2015 Tools installed.

Real problem is node-gyp (gulp-msbuild works OK with VS2017): i could not make it work with having only VS2017 installed (even though i installed the 14.0 toolset).

I'll do some tests in the future and I'll update the status of this issue. :)
If anyone has any comment about building the project with VS2017 would be very appreciated.

NPM publishing is currently broken due to the removed files-attribute in the package.json.

Broken in e91e4d9

See #11

EdgeDiagnosticsAdapter.exe does not respond
to "Control-C" from the command line while it is running. Instead I
have to perform a manual process kill.

Added by accident? https://github.com/Microsoft/edge-diagnostics-adapter/tree/master/Output

Debug console content when adding BP in code:
›SourceMaps.setBP: Mapped c:\HPSRC\Git\Handy\Handy.Client\app\modules\search\customer-search.component.ts to c:\HPSRC\Git\Handy\Handy.Client\app\modules\search\customer-search.component.js
›SourceMaps.setBP: Mapped c:\HPSRC\Git\Handy\Handy.Client\app\modules\search\customer-search.component.ts:32:0 to c:\HPSRC\Git\Handy\Handy.Client\app\modules\search\customer-search.component.js:54:20
›SourceMaps.setBP: Mapped c:\HPSRC\Git\Handy\Handy.Client\app\modules\search\customer-search.component.ts:71:0 to c:\HPSRC\Git\Handy\Handy.Client\app\modules\search\customer-search.component.js:91:20
›Paths.setBP: Resolved c:\HPSRC\Git\Handy\Handy.Client\app\modules\search\customer-search.component.js to http://localhost:8000/app/modules/search/customer-search.component.js
›To target: {"id":5,"method":"Debugger.setBreakpointByUrl","params":{"url":"http://localhost:8000/app/modules/search/customer-search.component.js","lineNumber":54,"columnNumber":20}}
›To target: {"id":6,"method":"Debugger.setBreakpointByUrl","params":{"url":"http://localhost:8000/app/modules/search/customer-search.component.js","lineNumber":91,"columnNumber":20}}
›From target: {"id":5,"error":{"description":"Not implemented"}}
›From target: {"id":6,"error":{"description":"Not implemented"}}
›SourceMaps.setBP: Mapped c:\HPSRC\Git\Handy\Handy.Client\app\modules\search\customer-search.component.js:54:0 to c:/HPSRC/Git/Handy/Handy.Client/app/modules/search/customer-search.component.ts:32
›SourceMaps.setBP: Mapped c:\HPSRC\Git\Handy\Handy.Client\app\modules\search\customer-search.component.js:91:0 to c:/HPSRC/Git/Handy/Handy.Client/app/modules/search/customer-search.component.ts:71
›To client: {"seq":0,"type":"response","request_seq":5,"command":"setBreakpoints","success":true,"body":{"breakpoints":[{"verified":false,"line":33},{"verified":false,"line":72}]}}

Most likely, looks like the error is thrown when trying to set a breakpoint in a file that isn't recognized by the adaptor. https://github.com/Microsoft/edge-diagnostics-adapter/blob/master/src/chromeProtocol/debugger.ts#L568

Hello,

I just came across this repository and was wondering what the roadmap for this project is and how much active support it has. From the github pulse, not that much.

I'm particularly interested to know if the purpose of this project is to make Edge have full compatability with the Chrome debugging protocol and how this project can be used in popular projects such as Lighthouse.

I am able to get a page where the opened tabs are listed, but when I click on them it will give a 404.
I realized no matter what port I started up edgeadapter as, it will always try to navigate to port 9223.

HTTP /json/version returns invalid JSON. Comma separators seems to be missing.

{
   "Browser" : "Internet Explorer 11.0.10586.162"
   "Protocol-Version" : "1.1"
   "User-Agent" : "Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 6.2; Win64; x64; Trident/7.0; .NET4.0C; .NET4.0E; .NET CLR 2.0.50727; .NET CLR 3.0.30729; .NET CLR 3.5.30729; Tablet PC 2.0)"
   "WebKit-Version" : "0"
}

Since we don't expose WebKit Remote Debugging Protocol but the Chrome Debugger Protocol, we should get rid of the WebKit naming in this project.

Does the adaptor support connections per debugging target? Might be worth documenting somewhere.

after starting EdgeDiagnosticsAdapter.exe with a custom port with the flag "--port"
the proxy starts on the given port, but prints the default port to the cmd line:

Proxy server listening on port 9222...

Passing the --help option, prints usage, along with an error ;)

ERROR: unrecognised option '--help'

Allowed options:
  -l [ --launch ] arg   Launches Edge. Optionally at the URL specified in the
                        value
  -k [ --killall ]      Kills all running Edge processes.
  -c [ --chrome ]       Launches Crhome in the background to serve the Chrome
                        Developer Tools frontend.

I'm trying to get Edge-diagnostics-adapter up and running on the latest Insider build of Windows 10.

I am able to get the list of open tabs up, but once I click on any of them, the node task exits with a typeError.

$ node -v
v6.12.3


$ node out/src/edgeAdapter.js --port=9222 --servetools
Edge Diagnostics Adapter listening on port 9222...
Log: Injecting 'browser:assert.js'
Log: Injecting 'browser:common.js'
Log: Injecting 'browser:browser.js'
Log: Injecting 'browser:dom.js'
Log: Injecting 'browser:runtime.js'
Log: Injecting 'browser:page.js'
Log: Injecting 'browser:CssParser.js'
Log: Injecting 'browser:browserTool.js'
Log: Injecting 'browser:network.js'
Log: Injecting 'debugger:assert.js'
Log: Injecting 'debugger:common.js'
Log: Injecting 'debugger:debugger.js'
Log: Could not open NetworkProxy at path: C:\Users\Jacob\AppData\Roaming\npm\node_modules\edge-diagnostics-adapter\out\src\adapterService\..\..\lib\NetworkProxy.exe
C:\Users\Jacob\AppData\Roaming\npm\node_modules\edge-diagnostics-adapter\out\src\adapterService\edgeAdapterService.js:190
                        edgeAdapter.forwardTo(networkInstanceId, msg.toString());
                                    ^

TypeError: Incorrect arguments - forwardTo(instanceId: string, message: string): void
    at TypeError (native)
    at WebSocket.<anonymous> (C:\Users\Jacob\AppData\Roaming\npm\node_modules\edge-diagnostics-adapter\out\src\adapterService\edgeAdapterService.js:190:37)
    at emitOne (events.js:96:13)
    at WebSocket.emit (events.js:188:7)
    at Receiver._receiver.onmessage (C:\Users\Jacob\AppData\Roaming\npm\node_modules\edge-diagnostics-adapter\node_modules\ws\lib\WebSocket.js:143:47)
    at Receiver.dataMessage (C:\Users\Jacob\AppData\Roaming\npm\node_modules\edge-diagnostics-adapter\node_modules\ws\lib\Receiver.js:389:14)
    at Receiver.getData (C:\Users\Jacob\AppData\Roaming\npm\node_modules\edge-diagnostics-adapter\node_modules\ws\lib\Receiver.js:330:12)
    at Receiver.startLoop (C:\Users\Jacob\AppData\Roaming\npm\node_modules\edge-diagnostics-adapter\node_modules\ws\lib\Receiver.js:165:16)
    at Receiver.add (C:\Users\Jacob\AppData\Roaming\npm\node_modules\edge-diagnostics-adapter\node_modules\ws\lib\Receiver.js:139:10)
    at Socket._ultron.on (C:\Users\Jacob\AppData\Roaming\npm\node_modules\edge-diagnostics-adapter\node_modules\ws\lib\WebSocket.js:139:22)`

The protocol.json is a key component for feature detection, and is used by various clients. We had a manual maintained file, which now have been removed.

Add GET /json/protocol endpoint to serve protocol.json bundled with the adaptor, to allow clients to feature detect the supported API.

I seems a bit inconsistent IMHO considering that the others are /json/version and /json/list. Would't be better to use /json/protocol instead?

Via cyrus-and/chrome-remote-interface#24 (comment)

Love the idea! Is there a roadmap?

Thanks

The Page.navigate action should return the frameId ("Frame id that
will be navigated."). However, the Page.frameNavigated event is
sending a value that has absolutely nothing to do with the result from
the Page.navigate call. Instead, the frame ID that gets returned is a
value that looks to be increasing by 100 each time, so 1600, 1700,
etc, while the Page.navigate frameId result is always 5000.1.

By report by Kenneth Shaw.