microsoft / bobsql Goto Github PK

On this page:
https://github.com/microsoft/bobsql/tree/master/demos/sqlserver2022/milinkdr

The 3rd bullet already requires SSMS, so perhaps move the 4th bullet to the top.
The 3rd bullet contains two steps. Perhaps break out to a separate bullet for each?

On this page:
https://github.com/microsoft/bobsql/tree/master/demos/sqlserver2022/IQP/psp

The script names are bolded, but not always. Not sure if you want to make them consistently indicated.

On this page:
I wonder if we need to include PowerShell az scripts to get the sub ids and such. Up to you - we can also just call it out.

On this page:
https://github.com/microsoft/bobsql/tree/master/demos/sqlserver2022/sqlledger

It starts with adding users, but I think the createdb.sql should come first?

This script: https://github.com/microsoft/bobsql/blob/master/demos/sqlserver2022/IQP/cefeedback/dbcompat160.sql

Gives this error:

Msg 911, Level 16, State 1, Line 24
Database 'AdventureWorksDW2016_EXT' does not exist. Make sure that the name is entered correctly.

Completion time: 2022-06-20T15:06:50.9740615-04:00

On this page:
https://github.com/microsoft/bobsql/tree/master/demos/sqlserver2022/milinkdr

Step three seems to repeat a pre-req step - is that intentional?

There are important files that Microsoft projects should all have that are not present in this repository. A pull request has been opened to add the missing file(s). When the pr is merged this issue will be closed automatically.

Microsoft teams can learn more about this effort and share feedback within the open source guidance available internally.

Merge this pull request

all folders containing code example have typo on their descriptions. for instance
Folder: ch2_intelligent_performance
Description: exmaples for 2019 book

Description should be: Examples for 2019 book

Hi Bob, great series.
I believe there is an incomplete file here: https://github.com/microsoft/bobsql/blob/master/demos/containers/sqlcontainers/step3_docker_restorewwi.sh
The WideWorldImporters-Full.bak downloaded with pullwwi.sh contains references to Drive D: and E: and is obviously taken from a windows server. How is that restored to a linux box?

Edit: I found the solution here: https://docs.microsoft.com/en-us/sql/linux/tutorial-restore-backup-in-sql-server-container?view=sql-server-ver15, but the file still needs mending.

Totally up to you, but do you want a script disclaimer at the start of the course about only running in test, etc. and do you want a standard script header comment block for each? I'm happy to help do that as we get closer to production.

On this page: https://github.com/microsoft/bobsql/tree/master/demos/sqlserver2022/IQP
For restoring the sample databases, recommend a step to create a c:\sql_sample_databases step to save time for the student. You do have in there to alter paths as necessary, but it's quicker if they just create the dir.

I think there's a problem with the definition of an external data source from SQL Server 2019 RTM to Azure SQL Database that affect the demo in
https://github.com/microsoft/bobsql/tree/master/demos/sqlserver/polybase/sqldatahub/azuredb

The problem is the one I opened with the documentation here:
MicrosoftDocs/sql-docs#3727

In short: it looks like unless you specify the database name in CONNECTION_OPTIONS when creating an external data source to Azure SQL Database with CREATE EXTERNAL DATA SOURCE, you get ODBC error Database is invalid or cannot be accessed.

I'm not changing the example scripts because it may be a regression in 2019 RTM...

This script seems to be empty - it isn't referenced anywhere, I assume either you stopped using it or still plan to later. Just letting you know it's there in case.
https://github.com/microsoft/bobsql/blob/master/demos/sqlserver2022/tempdb/disablegamsgam.sql

On this page:
https://github.com/microsoft/bobsql/tree/master/demos/sqlserver2022/containedag

Not sure if you meant "not" or "now" in this section:

Demo Steps
The following are steps to create a contained AG, create a database to be part of the AG, create a SQLAgent Job, and observe the agent job is replicated to the secondary. Then you will execute a manual failover to see how the agent job is not available as part of the new primary.

On step 9, I think the script is mis-named.

On this page https://github.com/microsoft/bobsql/tree/master/demos/sqlserver2022/IQP/dopfeedback Step 11 should probably say from CMD or PowerShell. In either case, it's not working for me - I did install the pre-reqs as requested.