microservice-api-patterns / lakesidemutual Goto Github PK

Currently, the risk management server doesn't start when using the provided docker-compose.yml. The problem lies in the way the volume is set up (https://github.com/Microservice-API-Patterns/LakesideMutual/blob/master/docker-compose.yml#L110), a /src directory is copied into the container, but no such directory exists. Copying the whole directory works, but requires the end user to install NPM dependencies locally.

I assume a correctly fix would be to change the way the volume is done, either by moving the source into a /src directory or configuring a .dockerignore to ensure dependencies (e.g. node_modules) isn't copied. For our use-case we were able to delete the volume for the time being.

Hi there ;)

Running LakesideMutual leads to changed Java files in customer-core/src.

Concretely, after running ./run_all_applications.sh, git status gives me several changes:

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

	modified:   customer-core/src/main/java/com/lm/ccore/Customer.java
	modified:   customer-core/src/main/java/com/lm/ccore/GetCustomerRequest.java
	modified:   customer-core/src/main/java/com/lm/ccore/GetCustomerResponse.java
	modified:   customer-core/src/main/java/com/lm/ccore/ObjectFactory.java
	modified:   customer-core/src/main/java/com/lm/ccore/Profile.java
	modified:   customer-core/src/main/java/com/lm/ccore/package-info.java

Maybe this is intended but I would expect that I don't have changes after "just running" the app; generated code should not be committed.
Or: if the source shall be visible for understandability: generate it into a separate source folder (for example src-gen), ignore it in .gitignore, and add/commit it with -f (force). Thereby you can commit it; but avoid that users/students have local changes after running the app.

Cheers!
Stefan

To be investigated

Hi Team,

I have tried to deploy all the micro-services over amd64 and arm64 platforms using ./run_all_applications.sh script and docker-compose method. All the services are running but it seems that the frontend is not able to establish a connection to the backend. It says the backend service is not running. But the spring boot admin page displays all the backend services running. Adding the log and UI as well.

• Lakeside_docker_compose_logs1.txt

• Lakeside_script_logs1.TXT

Dear LakesideMutual team

I have forked your project and experienced a few problems with the existing unit tests.
I would have expected every unit test to pass without any failures.
Unfortunately this is not the case, I will go into further details in the description below.

My Setup

• Windows
• IntelliJ IDEA 2023.2.2. (Ultimate Edition) Build #IU-232.9921.47
• JDK 21
• JUnit 'archunit-junit4' version 0.22.0 from the pom.xml

Customer-Core

• 26 tests executed
• 18 tests passed
• 8 tests failed

All tests in the class CustomerInformationHolderTests failed due to an IllegalStateException. The error messages says: "Failed to load ApplicationContext". I assume there is a Spring Configuratin missing for the test setup.

Customer-Management-Backend

• 10 tests executed
• 9 tests passed
• 1 test failed

The test layer_dependencies_are_respected in the class ArchitectureTests failed due to an AssertionError. It seems like there is a violation in the architecture principle.
I assume the test is failing because the package 'com.lakesidemutual.customermanagement.application' is not existing and thus empty.

Customer-Self-Service-Backend

• 12 tests executed
• 11 tests passed
• 1 test failed

The test rest_controllers_should_be_suffixed in the class ArchitectureTests failed due to an AssertionError. It seems like the class InsuranceQuoteRequestCoordinator does not apply to the given rules. The class should end with a suffix 'Controller', 'DataHolder' or 'InformationHolder'.

Policy-Management-Backend

• 19 tests executed
• 18 tests passed
• 1 test failed

The test rest_controllers_should_be_suffixed in the class ArchitectureTests failed due to an AssertionError. It seems like the class InsuranceQuoteRequestProcessingResource does not apply to the given rules. The class should end with a suffix 'Controller', 'DataHolder' or 'InformationHolder'.
Additionally I would expect the class RiskComputationService to fail in the same test case as well.

Further Enhancements
I would like to suggest to enhance the existing test setup. It seems like the current test setup is only testing the architectural setup. It would be a great improvement if also the functionality would be tested. Adding unit tests would make refactorings or changes to the existing application easier due to the possibility for regression testing.

Thanks a lot for the effort on your end. In case of further questions please do not hesitate to contact me.
Kind regards
Jan

Currently if i open the whole folder in Jetbrains IDE with new > import from existing source it does not reconize all subfolder and its projects. I do not want to open each subfolder seperatly and have multiple Windows open of same IDE.

Nice would then also having running configurations so

Possible solutions:

• commit .idea folder with basic settings (Only solution for IDEA Intellij, but running config would be possible too and it is very popular by students)
• a root pom.xml config which loads all projects in IDE (maybe https://www.baeldung.com/maven-multi-module)