michalsn / codeigniter4-uuid Goto Github PK

Hey @michalsn!

I'm getting this error:

Argument 1 passed to Michalsn\Uuid\Uuid::fromString() must be of the type string, null given, called in /castopod-host/vendor/michalsn/codeigniter4-uuid/src/UuidModel.php on line 381

This happens when trying to insert a record with a null value in a Uuid field that should be converted in bytes. Here is the line in question, in the doInsert method:

if (in_array($key, $this->uuidFields) && $this->uuidUseBytes === true)
{
    $val = ($this->uuid->fromString($val))->getBytes(); // line 381, $val is null
}

Given that you may have a Uuid field with possible null values, there should be a check to prevent this from happening.

Possible solution

Add a condition to check that the field value is not null for insert and update:

if ($val && in_array($key, $this->uuidFields) && $this->uuidUseBytes === true)
{
    $val = $this->uuid->fromString($val)->getBytes();
}

once I insert data and then tries to find that record with find method by providing primary key returned by insert call, It returns all the records
$model = new CommoditiesModel(); $commodity = $model->insert($input); $commodity_data = $model->find($commodity);

find call is returning all the records without any WHERE clause.

Is there any function in order to check if an string|binary variable is an uuid?

Hey @michalsn, first of all, thank you for this project!

I have stumbled on this error when trying to insert a record with the UuidModel's insert method:

The problem might come from this PR in CodeIgniter4.. Before then, inserting a record worked without hassle.

Possible solution

Changing the line from if ($result->resultID) to if ($result) fixes the problem.