Code Monkey home page Code Monkey logo

Comments (3)

MichalLytek avatar MichalLytek commented on May 18, 2024

Right now defaults are handled on JS side. You want to reflect that default in schema?
AFAIK, it affects only the visual aspect of graphiql docs:

image

The behavior is the same as now with defaults in JS.
Technically I could do this for input and args classes but not for inline @Arg() - I would have to introduce the defaultValue decorator option which doesn't look good for me 😕

from type-graphql.

j avatar j commented on May 18, 2024

Yeah, just schema default values. As of now, I'm just doing nullable with default JS values as you said. But it'd be nice to use the built-in version to get doc support. Although for internal APIs, I'm okay with having nullable args with internal defaults. Can @arg() take options to set defaultValue?

from type-graphql.

MichalLytek avatar MichalLytek commented on May 18, 2024

Yes, I will emit the defaultValue in schema for @ArgsType() and @InputType() from JS defaults and add an option for @Arg() decorator. But it's a minor feature with easy workaround so it has low prio for now.

If you want help, you can create a PR for @Arg() - it should be only a few lines of code to do that, but you would also need to add one test case for that. I would be grateful 😉

from type-graphql.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.