Code Monkey home page Code Monkey logo

Comments (15)

MichalLytek avatar MichalLytek commented on June 9, 2024 2

I guess this was me doing deps upgrade without checking build results:

Code_Ozb9w4fl7J

image

We now can't trick typescript to emit ESM for commonjs project, we need a real ESM project to emit ESM code.

from type-graphql.

maplesteve avatar maplesteve commented on June 9, 2024 2

Published v5, please check now if it works 😉

@MichalLytek the v5-package is nearly empty; the build directory is missing.

from type-graphql.

MichalLytek avatar MichalLytek commented on June 9, 2024 2

Thanks for the report. Our publish workflow is not working so I do publish by myself and something went wrong.

Should be ok now with 2.0.0-beta.6.

from type-graphql.

MichalLytek avatar MichalLytek commented on June 9, 2024 1

Should be fixed by 51ff280, will see in beta.5 if that works 😉

from type-graphql.

MichalLytek avatar MichalLytek commented on June 9, 2024

@carlocorradini Might this be related to ESM support?

from type-graphql.

carlocorradini avatar carlocorradini commented on June 9, 2024

ESM code is using require instead of import:
Screenshot_2024-01-05-14-50-46-14_40deb401b9ffe8e1df2f1cc5ba480b12.jpg

@MichalLytek How did you build the package?
I'll try locally to check if this is due to an upgrade of a dependency

from type-graphql.

carlocorradini avatar carlocorradini commented on June 9, 2024

@MichalLytek I confirm is the build process

from type-graphql.

MichalLytek avatar MichalLytek commented on June 9, 2024

@carlocorradini
image

from type-graphql.

carlocorradini avatar carlocorradini commented on June 9, 2024

@MichalLytek I've tried downgrading to typescript v5.1.6 (same as alpha) and manually:

npx tsc --build ./tsconfig.esm.json

And it does not works.
It looks like typescript is ignoring esm... WTF 😅
Any thoughts?

from type-graphql.

MichalLytek avatar MichalLytek commented on June 9, 2024

It was working as we've published beta 3 via gh actions 😄

from type-graphql.

carlocorradini avatar carlocorradini commented on June 9, 2024

@MichalLytek Yup, I've tried and we can't trick TypeScript anymore

from type-graphql.

nemanjastanic avatar nemanjastanic commented on June 9, 2024

Thanks!

from type-graphql.

MichalLytek avatar MichalLytek commented on June 9, 2024

@nemanjastanic Published v5, please check now if it works 😉

from type-graphql.

dahaupt avatar dahaupt commented on June 9, 2024

@MichalLytek I can confirm that the build directory is missing in 2.0.0-beta.5.

from type-graphql.

carlocorradini avatar carlocorradini commented on June 9, 2024

Apologize if the CI/CD is currently broken 😔
It's my fault
I'll fix it ASAP

from type-graphql.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.