michaeltroger / greenpass-android Goto Github PK

To mitigate #54, I'm wondering whether the app could retain the zoom level and position across Android lifecycle journey. Currently, the PDFs are rendered full page every time the app comes back to the foreground.

need button to print file please.

In case of sweaty fingers for example, this could be a lifesaver ;)

submitted via a Google Play Review

Is your feature request related to a problem? Please describe.
I was not able to import flight tickets/car parking lot provided in pkpass format:
https://en.m.wikipedia.org/wiki/PKPASS

Describe alternatives you've considered
I was able to use the image I also received by mail, but not with the wallet.

I can provide a sample pkpass file, however github would not let me attach it.

Right now first page is first pdf, that isnt perfect as you may not like to show it, so I would like optional first page with names of saved pdf

The QR code on the Canadian Vaccine Certificate is not extracted if there are more than 2 vaccine shots listed on the document. The reason for why there can be more than 2 vaccine shots listed on the document is if someone was to get a booster vaccine shot. The QR code on the Canadian Vaccine Certificate is still extracted if there are 1 or 2 vaccine shots listed on the document.

Hello,

Please, add an ability to show PDF doc full screen and/or resize it automatically to 100% of width/height.

Rationale: some countries (staring on Moldova) use covid certs in a4 "landscape" mode, not "portrait", so such doc is barely visible, because they are displayed on 50% of screen size in the app

...as we can only use Java 11 or 17 now: https://monitor.f-droid.org/builds/log/com.michaeltroger.gruenerpass/53#site-footer

ref: 8e070ce

But there's an upgrade to Debian Bookworm in progress so we might be able to install Java 19 or 21 from Debian Sid then.

anyway, which new feature you need from 21 that was not in 17?

/LE: fyi https://gitlab.com/fdroid/fdroiddata/-/commit/45f788be85af35fde977ef0242d95ec5c73590fa

I am going though apps that use old native libraries on F-Droid: https://gitlab.com/fdroid/fdroiddata/-/merge_requests/11496/

Your app uses com.tom-roush:pdfbox-android:2.0.1.0 using PDFBox 2.0.1 from 2016-04-22, which seems to have ~5 known security issues.
https://github.com/michaeltroger/greenpass-android/blob/40/app/build.gradle#L99

Newer versions are available: https://github.com/TomRoush/PdfBox-Android/releases

Hi

In France, certificates have two QR codes. One is to import the certificate into the official app, the other is the one that has to presented to be verified.

The app does not select the right one when zooming in. The one that should be used is the one in the top right quadrant (it's larger now than it is in the screenshot below)

Have a good day

First of all thanks for the nice little app!

Since some companies use weird QRCode-ish codes which obviously cannot be recognized, it would be an awesome addition to your app to optionally cut any code (or any other part) manually out of the PDF for the preview.

Edit:
...to support Aztec Code.

In my opinion it would be good idea to let users backup Green Pass application using Seedvault. Here you can see example of how such backup option could be implemented in privacy-respecting way. More details about it here. Thank you in advance.

I have tickets that use data matrix and EAN Barcodes. Could they be supported?
Can't you use some library for this similar to Barcode Scanner apps like the one I use do?

Is your feature request related to a problem? Please describe.
When you have sensitive documents in the app, then you might want to be sure that no screenshots are taken of them

Describe the solution you'd like
A setting to block the taking of screenshots

Describe alternatives you've considered
Blocking of screenshots could also be connected to whether fingerprint authentication is enabled. But a separate setting would be the more flexible solution

Additional context
To be defined:

• what's the default value
• think also about "recent apps" preview

Most likely the issue is similar to that of the NZ pass (QR code being too small). In my experience, only 1 out of 3 passes I tested over the past year had the QR code correctly identified and rendered — the others would just not be detected.

This is party alleviated by using the QR-code-only version of the pass, but it would be great if it could be fixed with the integral pass (sample below)

Sometimes people want to hold the phone in their hand to better hold the PDF in front of a reader or to better type off a code. Since the smartphone remains unlocked during this process, it isn't very secure, since you are giving away access to your smartphone.

Of course, you could say that you don't let the phone out of your hand, but would it be possible (e.g. as a setting) to display the current open PDF on the lockscreen when the app is open?

The app Transportr (https://github.com/grote/Transportr) does this for the current shown bus route: https://github.com/grote/Transportr/blob/187b5e7765e0f01813f806bf3500d12175cd78cf/app/src/main/java/de/grobox/transportr/trips/detail/TripDetailActivity.java#L82

After reposition of documents (right or left move), part of stored pdf docum


ents are not loaded. Green mark is moving and only the name of the document is visible. Also QR code is not loaded, but only pdf document under it is visible.
After few restart the documents are loaded. But the same problem starts from time to time without any action. Just after restart of the Appl.

Is your feature request related to a problem? Please describe.
When fingerprint authentication is enabled then there is no information when the session runs out, other than being redirected to the locked screen.

Describe the solution you'd like
It would be great to show an info text (snackbar at the bottom) for a couple of seconds after the session expired.

Describe alternatives you've considered
x

Additional context
Look at the George app for an example

I want to help you with translating the app to Russian, but I can't find the language listed in Crowdin, can you add it as a language in your app? I'm willing to help you with the translation.

Also I can translate your Google Play page, I'll try to soon.

QR Code is not extracted for the Slovenian Vaccine Certificate if there are more than 2 vaccine

Describe the bug
When scrolling through a PDF document with lots of pages quickly, then for a little while the wrong page content is displayed.

To Reproduce
Steps to reproduce the behavior:

1. Add a document with plenty of pages (e.g. 50)
2. Scroll down towards the last page
3. Quickly scroll up again towards the first page
4. You see a wrong page content (not in expected order) for a second or so, before the correct page content loads, fitting to the current position

Expected behavior
You should either see the correct page content right away or a loading indicator, before the correct page can be shown

Screenshots
x

Smartphone (please complete the following information):

• Device: Pixel 6
• OS: Android 14
• App Version 4.1.1

Additional context
This is most likely due to the way views are re-used in RecyclerViews. One idea to solve it is to remove the page content (the ImageView) after scrolling away and showing the loading indicator once more. Another idea could be to cache the pages so that they can be loaded quicker

Please add the dark Mode so we can read the pdf files with no pain in the eyes, thank you

The informations of both QRCodes stay identical though. Just the pixels are different.

To be honest I don't know if this creates a problem for other QRCode scanner. Just wanted to mention it fyi.

Feature request submitted per email.

The user argued the Google Drive PDF reader can zoom in quite a lot more

You write you support QR codes that are displayed in big then.

Unfortunately some tickets, most famously in Germany probably Deutsche Bahn, do have aztec codes, which are just another 2D encoding.

So could you add support for them, too?

Where can I find the current Uri in case that there is many pdf files opened and I change between them?

The app is really good, but some features are needed to be implemented

1. Custom catogories - we need catogories under which we can add our pdfs

2. A search button - to search any pdf by its name

3. Catogories share - to share all the pdfs present in a catogory

4. New Appearance - list for easier , for example like this
   

5. While it is in list mode, it should display name, size and pages of the pdf

Thank you for this amazing app, the app can be more amazing if the features can be added

Hello and thank you for this great idea of a very useful tool dealing with de-facto standard ticket format.

I tried to import a train ticket by Deutsche Bahn, which has a QRCode on the right bottom corner (international ticket) instead of the usual QRCode on the right top corner. Unfortinately the QRCode is not shown in big above the PDF - seems not to be recognized by the app...

Best regards

Lucas

Hello, thanks for the great app!
Could you add themed icon to fit with the apps on the launcher?

Hi,

Thanks for the app, it great to have a simple offline way to do this.

I imported my NZ vaccine certificate into the app, but it doesn't recognise and extract the QR code. Could be that it is too small for the scanner?

For reference our vaccine certificates look like this:

...with the PDF version I imported being formatted exactly like the center image.

Thanks again, please let me know if you need more information or if I can help in any way.

Problem to adress: Not part of the "open with"-list

Description: Opening a PDF file doesn't invite the user to open with "Green Pass". Only way to open PDFs seem to be through the app. An auto add to wallet and read, would be a practical automation.

Green Pass PDF Wallet version
2.3.2
One UI version
4.1
Android version
12

Hi

Thank you for such a easy application would like to have a signature Feature's, a button where we can select the digital signature and paste to sign, like in nitro and adobe Acrobat,

Thank you

Describe the bug
The app crashes when in List Layout, a document is added and then quickly another document is selected during import.

To Reproduce
Steps to reproduce the behavior:

1. List view is active
2. At least 1 document imported already
3. Import another document
4. Before the detail screen is automatically opened, click another document
5. App crashes

Expected behavior
App should not crash

Screenshots

Smartphone (please complete the following information):

• Device: Pixel 6
• OS: Android 14
• App Version 4.1.0

Additional context

Hi,

I'm actually opening this issue mainly to thank you for your great work! I use the app regularly and I love how simple the idea is and how versatile it is: train, movie or concert tickets or just any important document that you want to have at hand, everything can be found quickly and easily in one place. Ingenious!

So, now to my suggestion: A barcode type that is used quite frequently but is not yet supported is PDF417. I think it would be great if this type were also supported at some point.

Keep up the great work!

The current implementation limits the page zoom to its display frame, which is quite inconvenient if you want to show an enlarged fragment in full screen. I suggest adding a full screen zoom mode when you tap on a page (maybe double tap or something similar).

Click to expand

Feature request received via Email:
"Maybe you can add an option for set the luminosity at the maximum when we use the app.

It's a little bit annoying to do it manually"

Describe the bug
Thanks a lot for the experimental support of Aztec codes ️❤️
Am I the only one who have trouble getting the code of D-Tickets (Deutschland from Deutsche Bahn) recognized?
Even if I zoom in extremely, there is no chance to workaround.

To Reproduce

1. Open the app.
2. Add a D-Ticket (with Aztec code)
3. Zoom as much as you like, all day long
4. Scratch your head why the code could not be recognized

Expected behavior
Maybe it's just me or my understanding of what the app should do. But I thought, the (Aztec) code should be "extracted" and shown as a bigger version on top of app. But this not happens. It's just opens the D-Ticket and shows it as every other PDF app does.

Screenshots

Of course the distortion was added later, for the screenshot.

Smartphone (please complete the following information):

• Device: Pixel 8
• OS: Android 14
• App Version: 4.1.1

Original issue: #73
requested by AminGholizad