michaelbaudino / addic7ed-ruby Goto Github PK

Hello there,

Nokogiri requires to build a native C extension (and the presence of libxml2-dev & libxslt1-dev).
It can become a real pain to have it installed & working on some NAS / Mediacenter systems.

Is Nokogiri really required here?

ATM, it just says A subtitle already exists (/data/public/Series/The Walking Dead/Saison 03/The.Walking.Dead.S03E08.720p.HDTV.x264-EVOLVE.srt). Skipping.

Hi,
Thank you for your job!
Maybe I missed something (like an option) but why downloading the "best subtitle" (that is the most downloaded?) instead of the subtitle that is matching with the "group" of the file?
Here is an exemple:
!----------------------------------------------------------
show: Mr. Robot
season: 1
episode: 3
tags: ["INTERNAL", "720P", "HDTV", "X264"]
group: KILLERS
distribution:
Available subtitles:
http://www.addic7ed.com/original/102176/14 -> ASAP (French, Completed) [5980 downloads]
http://www.addic7ed.com/original/102176/15 -> KILLERS (French, Completed) [3073 downloads]
http://www.addic7ed.com/original/102176/16 -> WEB-DL (French, Completed) [2093 downloads]
http://www.addic7ed.com/original/102176/17 -> WAREZNIK (French, Completed) [605 downloads]
Best subtitle:
http://www.addic7ed.com/original/102176/14 -> ASAP (French, Completed) [5980 downloads]
New subtitle downloaded for /Users/user/Downloads/Mr_Robot/Mr. Robot.S01E03.INTERNAL.720p.HDTV.x264-KILLERS.mkv.
Enjoy your show :-)
!----------------------------------------------------------

Is there any way to force the program to download the corresponding subtitle regarding the group?

Thank you.

Hi,
First of all, more than an issue ticket, this is a suggestion.

When running the scraper, using the following example:

$ addic7ed -l fr /path/to/Californication.S06E07.720p.HDTV.x264-2HD.mkv

I end up with the two following files:

$ ls
Californication.S06E07.720p.HDTV.x264-2HD.mkv
Californication.S06E07.720p.HDTV.x264-2HD.srt

So far, so good. But wouldn't it be great to keep addic7ed file name instead of the mkv file name ?
ie: "Californication - 06x07 - The Dope Show.2HD.French.updated.Addic7ed.com.srt/mkv"

or EVEN BETTER keep only the serie/episode part (Californication - 06x07 - The Dope Show.srt.mkv)

I would have done it myself and proposed a pull request for it but I don't know ruby syntax at all...

Thanks anyway for the good work, keep it up!

Currently, subtitles for some shows cannot be found, although they are available on Addic7ed. Examples are "DC's Legends of Tomorrow" and "The Flash (2015)"? In both cases, the release name extracted from the video file differs slightly from the name used on Addic7ed.

We could build a very simple web tool (a Rack/Sinatra app on a $7/mo Heroku lobby instance) where a user can drag-n-drop a video file, an HTML5 API call grabs the file name, searches for a subtitle, and redirects to it so the user browser downloads it directly.

A textbox could also be available if people want to enter a filename directly.

The frontend would be a JS/HTML5 small app that calls the Sinatra app, that would the be a proper API (with very simple spec like GET /subtitle/:video_file_name # => HTTP 301 to the subtitle).

Hi,

I get following error:

    bin/addic7ed:115:in `rescue in block in <main>': undefined method `filename' for
    #<Addic7ed::Episode:0x0000000140c2b0> (NoMethodError)
    from bin/addic7ed:83:in `block in <main>'
    from bin/addic7ed:77:in `each'
    from bin/addic7ed:77:in `<main>'

bin/addic7ed:

  rescue Addic7ed::ShowNotFound
    puts "Show not found on Addic7ed : #{ep.filename.showname}. Skipping.".gsub(/^/, options[:verbose] ? '  ' : '') unless options[:quiet]
    next
  rescue Addic7ed::EpisodeNotFound
    puts "Episode not found on Addic7ed : #{ep.filename.showname} S#{ep.filename.season}E#{ep.filename.episode}. Skipping.".gsub(/^/, options[:verbose] ? '  ' : '') unless options[:quiet]
    next

"ep.filename.episode" should be "ep.file.episode"

Regards

Hej

I am getting the hearing impaired version of the subtitles when i use the script. Any work a round?

For example, The.Americans.2013.S01E04.720p.HDTV.X264-DIMENSION.mkv cannot be guessed properly : Addic7ed does not use "The Americans 2013" not "The Americans (2013) but only "The Americans".

We should use mruby-cli or traveling-ruby to build native command-line binaries for multiple systems.

Hi Michael.

I'm using your auto downloader for a while now, but I notice that I have a lot of difficulties for the last month.

Example:

Searching subtitles for Star.Crossed.S01E06.HDTV.x264-LOL.mp4
  Guesses for Star.Crossed.S01E06.HDTV.x264-LOL.mp4:
    show:    Star Crossed
    season:  1
    episode: 6
    tags:    ["HDTV", "X264"]
    group:   LOL
  No (acceptable) subtitle has been found on Addic7ed for Star.Crossed.S01E06.HDTV.x264-LOL.mp4. Maybe try again later.

But on the addic7ed website:

This happens a lot with Marvel Agents Of S.H.I.E.L.D. too.

Thanks a lot,
Litz.

We should remove the CLI script from this project to make it a pure Ruby library.

CLI should be moved to a addic7ed-cli project which uses addic7ed-ruby (and powered by Thor or GLI).

It should take away from the API gem both the actual CLI code (the bin/addic7ed file) and the actual downloading of the subtitle file (the API gem should only return the URL).

When the show name contains a quote (Marvel's, Grey's Anatomy, ...) it's not recognized correctly.

Addic7ed previously added a tiny yellow warning that we used to detect that no subtitle is available for the requested language. They removed it, so this gem is now retrieving a random language subtitle when the requested language has absolutely no available subtitle.