michael-rapp / tries Goto Github PK
View Code? Open in Web Editor NEWProvides different Java implementations of tries (prefix trees)
License: Apache License 2.0
Provides different Java implementations of tries (prefix trees)
License: Apache License 2.0
Hi,
AbstractTrie
seem to be converting empty sequences into null
s, which causes some soundness issues:
import de.mrapp.tries.PatriciaTrie;
import de.mrapp.tries.sequence.StringSequence;
import org.junit.Test;
import java.util.*;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertNull;
public class TrieTest {
@Test
public void test1() {
PatriciaTrie<StringSequence, String> trie = new PatriciaTrie<>();
trie.put(s("foo"), "foo");
assertEquals("foo", trie.get(s("foo")));
assertNull(trie.get(null));
trie.put(s(""), "empty");
assertEquals("empty", trie.get(s("")));
assertNull(trie.get(null)); // fail
assertEquals(new HashSet<>(Arrays.asList(s("foo"), s(""))), trie.keySet()); // fail
trie.put(null, "null");
assertEquals("null", trie.get(null));
assertEquals("empty", trie.get(s(""))); // fail
assertEquals(new HashSet<>(Arrays.asList(s("foo"), s(""), null)), trie.keySet()); // fail
}
private static StringSequence s(String str) {
return new StringSequence(str);
}
}
Even if you don't insert null
sequences, you have to handle them when walking the trie, and it kind of breaks the Map
contract since both null
and the empty sequence are using the same value slot, even thought they are not equals.
Even if I personally have no use for null
keys since sequences already have a zero value (the empty sequence), I could understand that someone else find it useful, but I think users that don't insert null
s shouldn't have to handle null
s on output.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.