Code Monkey home page Code Monkey logo

tries's People

Contributors

michael-rapp avatar

Stargazers

 avatar

Watchers

 avatar  avatar

tries's Issues

AbstractTrie is confusing the empty sequence and null

Hi,

AbstractTrie seem to be converting empty sequences into nulls, which causes some soundness issues:

import de.mrapp.tries.PatriciaTrie;
import de.mrapp.tries.sequence.StringSequence;
import org.junit.Test;

import java.util.*;

import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertNull;

public class TrieTest {

  @Test
  public void test1() {
    PatriciaTrie<StringSequence, String> trie = new PatriciaTrie<>();

    trie.put(s("foo"), "foo");
    assertEquals("foo", trie.get(s("foo")));
    assertNull(trie.get(null));

    trie.put(s(""), "empty");
    assertEquals("empty", trie.get(s("")));
    assertNull(trie.get(null)); // fail
    assertEquals(new HashSet<>(Arrays.asList(s("foo"), s(""))), trie.keySet()); // fail

    trie.put(null, "null");
    assertEquals("null", trie.get(null));
    assertEquals("empty", trie.get(s(""))); // fail
    assertEquals(new HashSet<>(Arrays.asList(s("foo"), s(""), null)), trie.keySet()); // fail
  }

  private static StringSequence s(String str) {
    return new StringSequence(str);
  }

}

Even if you don't insert null sequences, you have to handle them when walking the trie, and it kind of breaks the Map contract since both null and the empty sequence are using the same value slot, even thought they are not equals.

Even if I personally have no use for null keys since sequences already have a zero value (the empty sequence), I could understand that someone else find it useful, but I think users that don't insert nulls shouldn't have to handle nulls on output.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.