michael-e / members-forms Goto Github PK

With the release of version 1.3 of the Members extension, example forms should include a hidden field for the Members section's ID. (

Hi Michael,

Sorry to create an issue for this - I think the issue is my misunderstanding.

My members section has some custom fields (address fields, mainly) that need to be entered at registration, and are defined as required in the section.

I merrily edited my working copy of utilities/members.form-register.xsl:

<xsl:call-template name="members:input">
    <xsl:with-param name="field" select="'address-1'"/>
    <xsl:with-param name="event" select="$event"/>
</xsl:call-template>

The form HTML output label and input attribute values are blank.

Is this because:

1. members-forms isn't intended to do this, and I should add the custom fields labels and inputs myself (or maybe use form-controls)?
2. I need to add the fields and their possible XML error messages to members.config.xsl?

See forum discussion. Using multiple forms on one page may generate fields with the same IDs, which does not validate (and may lead to problems if you actually use those IDs, e.g. in CSS or JavaScript).

In Symphony 2.2.5, the XML returned for an error result for a failed registration attempt is like this:

<email label="Email" type="missing" message="'E-Mail' is a required field." />

The line in `members.config.en.xsl' is:

<email type="missing" message="E-Mail is a required field."/>

Shouldn't the default message attribute values have the single quote marks in to match Symphony's defaults, like this?:

<email type="missing" message="'E-Mail' is a required field."/>

When I added the single quote marks, the E-Mail field was then applied the invalid class when the E-Mail field was left blank.

One other thing: lines 73-76 have the German word Passwort and not Password. Should these lines contain the English version?

If these things should be corrected, please let me know if I should submit a pull request.

Thanks.

<xsl:with-param name="redirect" select="substring-before($current-url, '?')"/>

That destroys success XML and is tricky to catch. I suggest removing it.

Hi Michael,

I just wanted to suggest usingxml for the config data, rather than an xsl variable. The xsl variable needs parsing through exsl:node-set() where an xml document can be loaded into a variable using document() function, and therefore already be a node-set.

Just a thought. :)

Also, I've been having a play, and I may make an extension based on this concept, to allow the event and field messages to be set via the admin... Don't wait on that though, my schedule is tight.

There's an extra 's' in 'Save Password' in line 188.

Two things have changed:

• All error message customizations have been moved to the password field and are simply repeated in the confirmation field. This means that both fields will be rendered invalid.
• at the top of the config file there should now be a configuration setting for using password postbacks.

@hypnosis: Can you please send a pull request for this? I don't want to ruin your translation!