metonym / svelte-link Goto Github PK

Hey just a small feature request — it would be great if the default for outbound was a little smarter, and defaulted to true if href is an external URL, which the user can easily override with outbound={false} to force all links to be same-target.

This would be especially useful if you don't have control over the href, for example in content from a CMS, where you want external links to automatically be outbound.

Happy to submit a PR if you're open to it

When importing svelte-link into a typescript project, it gives the following error (at least in VS Code):

JSX element class does not support attributes because it does not have a '$$prop_def' property

Using the new SvelteComponentTyped base class in Link.d.ts fixes the issue, but not sure if this should be a PR here or against sveld

export default class Link extends SvelteComponentTyped<LinkProps> {}

A regular use-case for a generic Link component is simply to add an .active (most common) class for styling differences, indication of navigation, etc, rather than adding that logic to each link's implementation code.

If you added that automatic injection when a route prefix matches (for deep navigation) with an exact modifier to force a full path match, that would be awesome...

<Link href="/about">About</Link>
<!-- when viewed at "/about/somewhere" should render: -->
<a href="/about" class="active">About</Link>

<Link href="/about" exact>About</Link>
<!-- when viewed at "/about/somewhere" should render: -->
<a href="/about">About</Link>

Just a suggestion!