Code Monkey home page Code Monkey logo

Comments (3)

huhk-sysu avatar huhk-sysu commented on May 12, 2024 4

I think the problem comes from here:

In Observer.js, line 21~25

this.Socket.onevent = (packet) => {
    Emitter.emit(packet.data[0], packet.data[1]);  // !!!!

    if(this.store) this.passToStore('SOCKET_'+packet.data[0], packet.data[1])
};

While packet.data contains the event's name and the arguments:
image

I'm not clear why to use only the first two arguments instead of all of them.

Maybe it should be written in this way:

this.Socket.onevent = (packet) => {
    Emitter.emit(...packet.data);

    if(this.store) this.passToStore('SOCKET_'+packet.data[0], ...packet.data.slice(1))
};

Now it can normally handle multiple arguments.

from vue-socket.io.

jeystaats avatar jeystaats commented on May 12, 2024

+1 for @huhk-sysu , I'm using Laravel Echo in combination with Vue-Socket. And Echo returns three arguments, Event, Channel and data. Now Vue-Socket is kinda useless with this combination because it always returns the channel-name. Example below :
screen shot 2017-05-02 at 10 43 24
Love to see a new update! 👍

from vue-socket.io.

michgeek avatar michgeek commented on May 12, 2024

vuex mutations and actions do not support multi arguments as per the documentation https://vuex.vuejs.org/en/mutations.html You will need to use object payload if you need multiple arguments

The signature of mutations and actions are described there https://vuex.vuejs.org/en/api.html

mutations: {
  increment (state, payload, options) {
    state.count += payload.amount
  }
},
actions: {
  checkout (context, payload, options) {
     // ....
    )
  }
}

All changes for multiple arguments should have never been merged. Build 2.1.1-b is not compatible with store vuex

from vue-socket.io.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.