Comments (15)
I don't understand why this issue was labeled as "low priority". It's not at all since this bug is actually breaking a functionality.
I confirm what @shadowRR described, this is how I got the issue too.
from blaze.
Actually, i've been able to reproduce the problem. Not sure of what's happening. Here's how i'm getting the problem :
If i have a template with ui two column computer one column mobile grid container
, without another template loading inside of it, then no problem, the two column
are there. But if i load a template inside it (like you're repo is doing) then i loose the column
on the first template, but the second template is fine, even if i have another two column
in it, and as long as i don't load a third template in the second, in which case the column
are reduced to one on the second template too...
Is it what you've found ?
from blaze.
Please see discussion in this pull request. Blaze is behaving based on the HTML5 spec:
The classes that an HTML element has assigned to it consists of all the classes returned when the value of the class attribute is split on spaces. (Duplicates are ignored.)
(Emphasis mine.)
And Meteor is ignoring duplicates per spec.
from blaze.
Can you explain why repeating classes is important?
from blaze.
Do you have an idea how this could be optional behavior?
from blaze.
I'm just moving issues over as per #25. Not by priority but from top to bottom to slowly move them over. Maybe we could get some priority labels as well as this one in particular isn't a high priority.
The Semantic-UI Framework sometimes needs repeated classes, which Meteor merges to one instance in the HTML which breaks the UI. Though this is an edge case of CSS use, there may be users who rely on this or other frameworks that adopt this pattern.
Does it need to be optional? Is there a case where duplicate classes are bad and need to be stripped?
from blaze.
Does it need to be optional? Is there a case where duplicate classes are bad and need to be stripped?
I would say esthetics. :-)
from blaze.
And thanks for copying the issue over. I labeled it as low priority.
from blaze.
@StanLindsey Is this issue supposed to break every time when using the same class twice on the same html tag ? I'm asking because i've just used the ui middle aligned center aligned grid
on a new app, which use the latest SUI package from atmosphere and Meteor v.1.3.2.4, and it's working, both aligned
are shown, and SUI works as expected...
from blaze.
Well, if nobody can replicate it then I guess we have our first closed ticket.
My issue now is we will need to close the meteor/meteor ticket to make things easier for us to move forward with the rest of the issues.
from blaze.
So that might be the exact symptom.
from blaze.
I am the author of the PR and would be willing to help if the need be, though I think I tried to explain what my one-liner does hehe.
Basically the problem appears whenever Blaze updates a template. So you can see it pretty easily with Dynamic templates.
from blaze.
+1 i have this issue with blaze this is why I'm switching slowly to react, but I'm not happy about it some stuff are easier with react but other are harder.
from blaze.
I guess this can be closed now as technically its an issue with Semantic-UIs use of class names and not Blaze.
from blaze.
As a consequence of fixing #141 order inside inline style
and class
attributes is now preserved. Duplicate values are still not supported.
from blaze.
Related Issues (20)
- Move codebase to ES6 HOT 15
- spacebars-tests packages still uses removed code
- Blaze.remove() destroys DOM before calling onDestroyed() HOT 8
- Error handling, callbacks and DOMRange HOT 9
- Errors in onCreated callback cause a complete stop for rendering further Templates
- Bootstrap select picker is not correctly removed / disposed during Template descruction HOT 6
- Add benchmarks to tests
- SSR is broken in 2.6.0 HOT 4
- Add ts types HOT 3
- Blaze compile errors completely silent if imported HOT 12
- Be able to have more contentBlock in template HOT 1
- Non-primitives not fully reactive in 2.7
- Complete GitHub community standards HOT 7
- CI/CD for documentaiton
- observe-sequence has a bug when _ids have a period HOT 11
- Possibility of a release for people wanting to update to be able to migrate their templates to ASYNC? HOT 4
- Support for async dynamic attributes HOT 3
- Measure performance impact of recent async changes HOT 1
- TypeError: `Cannot convert undefined or null to object` in `waitForAllAttributesAndContinue` HOT 3
- Allowing arbitrary expressions
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from blaze.