observe-sequence has a bug when _ids have a period about blaze HOT 11 OPEN

Confirmed - it's working, we've had it running in production (a busy site) for at least 3 months at this point

from blaze.

Hi @znewsham to which Blaze version did you upgrade?

from blaze.

[email protected]

but probably more importantly

[email protected]

from blaze.

Is it fixed if you upgrade to Blaze @2.71 and [email protected]

from blaze.

It doesn't look like it is - the problem is with the has function, which doesn't change between those two versions. In short, I don't think has should be used when looking at posOld - it should also be fairly easy to reproduce

from blaze.

You're right, I had a similar issue with non-reactive #each blocks in 2.7.0 but they were related to another cause.

The has is actually simply the replacement for _.has as taken from here: https://you-dont-need.github.io/You-Dont-Need-Lodash-Underscore/#/?id=_has

However, since _.has worked before, we should at least check how it works (https://underscorejs.org/docs/modules/has.html) and update the has function accordingly. What do you think?

Edit: we should also update the tests accordingly as it seems this regression was never catched by the tests somehow

from blaze.

The difference is, _.has doesn't expand a.b.c into ['a', 'b', 'c'] - so just like _.get - if you want to recurse, you have to split the string yourself. so _.has(obj, 'a.b.c') is equivalent to Object.hasOwnProperty.call(obj, 'a.b.c')

from blaze.

It looks like https://you-dont-need.github.io/You-Dont-Need-Lodash-Underscore/#/?id=_has is wrong - or maybe referencing a specific version?

from blaze.

I think it's neither. I really think it's extended but not documented as such

from blaze.

@znewsham do you mind helping out in #426 ? We need confirmation that the fix does remove this issue but does not introduce any side-effects

from blaze.

@znewsham fiendly ping. If you can confirm this basically running I will write one or two tests and pushb this to the release queue. If you find it hard to test we could also to an RC release

from blaze.