Clean is removing actual fields whose names are subsets of virtual fields. about meteor-simple-schema HOT 6 CLOSED

Hmm, yes that line might be backwards, and should probably check for the key plus "[" as well as an exact match, something like:

if (p === position || p.slice(0, position.length + 1) === position + "[") {

Basically the slice stuff is there because if we delete a property's value and that value was an array or object, then we need to be sure to delete everything that was within that array or object, too.

I'll have to add some tests, make this change, and make sure this fixes it.

from meteor-simple-schema.

Ah, I see, thanks!

from meteor-simple-schema.

@aldeed I ran into another issue with virtual fields that I didn't get entirely to the bottom of. I had two different collection2's race & result. race had virtual fields and result did not. Under certain circumstances race's virtual field functions were being passed results. I spent some time trying to get to the bottom of it and I could clearly see a result being passed to a race virtual field function in the debugger. Due to the fact that virtual fields are probably being deprecated and collection-helpers was the recommended replacement I decided to go ahead and make the switch rather than debug the issue further and so far so good!

from meteor-simple-schema.

@mjgallag, that's strange. Virtual fields are implemented through the collection's transform option, and the object passed in to the virtual field function is actually the same object being passed to the transform function. So one interesting test would be to see if you can replicate with a custom transform function and a normal schemaless collection. In other words, it might be a general issue with transforms in the mongo-livedata package, so that should be ruled out first.

from meteor-simple-schema.

If it helps at all the issue was around here: https://github.com/aldeed/meteor-collection2/blob/master/collection2.js#L35 the doc was from one collection2 and the virtualFields were from another. When I switched to collection-helpers the issue went away. I'm willing to revert back to Virtual Fields temporarily to help you test fixes if you're interested, just let me know. Wasn't sure how much time you wanted to spend if you were deprecating them anyway, and like I said, collection-helpers is working well for me so far. Thanks!

from meteor-simple-schema.

We can wait and see if anyone else reports this issue. As you said, using collection-helpers is better anyway.

from meteor-simple-schema.