Code Monkey home page Code Monkey logo

Comments (6)

jankapunkt avatar jankapunkt commented on June 13, 2024 1

Hi @bruceborrett there is not types definition yet. Are you experienced with TypeScript? I am not yet so I need help to provide one. If you would consider adding one then feel free to open a PR

from meteor-simple-schema.

bruceborrett avatar bruceborrett commented on June 13, 2024 1

I see, so then, in my opinion, this package should never have been forked, the latest simpl-schema is still perfectly compatible with Meteor (its framework agnostic now) and is being well maintained. It is in fact the Collection2 package which is no longer compatible with simpl-schema, and Collection2 acts as the glue between simpl-schema and Meteor. In my opinion Collection2 should rather be updated to work with the latest simpl-schema, perhaps it can even be extended to support other validation libraries such as Zod and Yup etc.

from meteor-simple-schema.

github-actions avatar github-actions commented on June 13, 2024

Thank you for submitting this issue!

We, the Members of Meteor Community Packages take every issue seriously.
Our goal is to provide long-term lifecycles for packages and keep up
with the newest changes in Meteor and the overall NodeJs/JavaScript ecosystem.

However, we contribute to these packages mostly in our free time.
Therefore, we can't guarantee your issues to be solved within certain time.

If you think this issue is trivial to solve, don't hesitate to submit
a pull request, too! We will accompany you in the process with reviews and hints
on how to get development set up.

Please also consider sponsoring the maintainers of the package.
If you don't know who is currently maintaining this package, just leave a comment
and we'll let you know

from meteor-simple-schema.

bruceborrett avatar bruceborrett commented on June 13, 2024

Well, the simpl-schema NPM package is written completely in Typescript, so the definitions are already there, for some reason they just not being made available when installed as part of this Meteor package.

from meteor-simple-schema.

jankapunkt avatar jankapunkt commented on June 13, 2024

@bruceborrett ah I see now. The Simple Schema NPM package dropped Meteor support in their 3.x major release, which is why this package is a hard-fork of the latest Meteor compatible version 1.13.1 which at that time did not contain any typescript code.

This also why we just can't copy the type definitions from the NPM repo as they are not reflecting the code in this Meteor package.

Edit_ Note, that with the dropped Meteor support there will also be trouble with async in Meteor 3.0 if you continue to use the npm package as we need basically all computable fields to be async-compatible in order to support any validations or computed properties that involve Mongo Collection calls.

from meteor-simple-schema.

bruceborrett avatar bruceborrett commented on June 13, 2024

I want to close this ticket and rather look at updating the collection2 package to support the latest simpl-schema, unless anyone can tell me why thats the wrong approach?

from meteor-simple-schema.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.