metamask / eth-hd-keyring Goto Github PK

When running MetaMask and attempting to create a bulk group of secp256k1 addresses, my browser is spending a lot of time computing the comb10MulTo (10 seconds on 123 addresses / ~50% total runtime) that is downstream of the addAccounts used in the eth-hd-keyring package.

Has anyone here run into this when bulk generating addresses in the browser using eth-hd-keyring? Running the program outside of the browser takes 2.43ms for 100 address via the test methods.

I understand that the browser computation will be slower but is 500x slowness expected?

CallTrace for reference:

🚨 You need to enable Continuous Integration on all branches of this repository. 🚨

To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because we are using your CI build statuses to figure out when to notify you about breaking changes.

Since we did not receive a CI status on the greenkeeper/initial branch, we assume that you still need to configure it.

If you have already set up a CI for this repository, you might need to check your configuration. Make sure it will run on all new branches. If you don’t want it to run on every branch, you can whitelist branches starting with greenkeeper/.

We recommend using Travis CI, but Greenkeeper will work with every other CI service as well.

Once you have installed CI on this repository, you’ll need to re-trigger Greenkeeper’s initial Pull Request. To do this, please delete the greenkeeper/initial branch in this repository, and then remove and re-add this repository to the Greenkeeper integration’s white list on Github. You'll find this list on your repo or organiszation’s settings page, under Installed GitHub Apps.

This project is missing a license file

non-refixed hex string a non-standard format for eth addresses

Hello:
I want to bridge some BTCBAM tokens from its native network ‘BTCBAM’ to Ethereum (ERC20) network, so I can get some wrapped BTCBAM tokens.
I know its contract address on BSC is: 0x79abC799ae4B749C01e07a60c8687A49D128eA1C
But my MetaMask wallet address is EVM address like: 0x…., I can find one BTCBAM native address is something like this: Bq4Ei1WxgnN6VD5jxeTtMSdvLfK8as7sJM
In order to bridge BTCBAM from its native address to ERC20 address, I think I need some BTCBAM address in my MetaMask wallet, right? But how can I get one of such address.
I found some articles from BTCBAM web site talking about BTCBAM wallet, I think those address in BTCBAM wallet should be the native network address.
I want to know if I can use BTCBAM wallet to generate a deposit address, and export the address using the wallet private key, then use MetaMask wallet to import the native BTCBAM address with its wallet private key. If it works, then I can add native BTCBAM wallet address in my MetaMask wallet, then later on go to some bridge web site, to bridge the BTCBAM tokens from its native network to ERC20 network, I want to get the wrapped BTCBAM tokens on ERC20 network.
Please advise if I think in the correct way or not.
Thanks,

We should standardize error codes such that consumers don't have to identify errors by message.

Related: MetaMask/eth-simple-keyring#29

MetaMask uses BIP32 HD keys, which means a single root seed phrase can result in many wallets. Unfortunately, it calls deriveChild(i) where i is a small number which means the additional keys it generates are not hardened. A non-hardened key (as I understand it) is one that could be associated with other un-hardened keys correlated with the account. This means if someone knows one of your MetaMask accounts, they can correlate it with your other MetaMask accounts.

I recommend adding a way for users to derive hardened keys. Using the current library, this is done by passing in a very large number for i to deriveChild(i). You can see the hdkey library for details.

We should strive for 100% unit test coverage, and to cover all input boundary conditions.

We want to migrate this package to TypeScript to reduce regressions and improve compatibility with our other TypeScript projects.

This project should use the shared ESLint config