metalface-oss / aspnetcore-servertiming Goto Github PK

Why injection is Singleton of IServerTimingRecorder.
This is causing every call on WebApi to keep the previous metrics. Please change to Scoped.

Why recorder's methods are called BeginRecord and EndRecord?

Naming was chosen to be visually similar to Asynchronous Programming Model (APM) and while it shares nothing more in common, such naming convention may be familiar to many .NET developers. Calling these methods will not change identation of your existing code (unlike using using statements) and diffs will be small.

Do I need to pass a metric name to EndRecord?

Usually, you don't. The last started recording is ended if the metric name is not provided.

May I use the same metric name multiple times?

Yes, if previous recording is ended. Server-Timing Working Draft allows duplicate metric names:

A response MAY have multiple server-timing-metric entries with the same metric-name, and the user agent MUST process and expose all such entries.

May I record a custom metric if I already know duration?

Yes, by calling Record(name, duration, description) method.

Microsoft have released this security advisory - dotnet/runtime#49377 - which is impacting your library through its use of [email protected].
As version 2.2.0 is built on .net Core 2.2 is is now out of support, so they will not be fixing it - dotnet/aspnetcore#31572 - and projects should upgrade to .net core 3+

Related to dotnet/aspnetcore#3612
Requires .NET Core 3.0