meshery / meshery-tanzu-sm Goto Github PK

Dependabot can't resolve your Go dependency files.

As a result, Dependabot couldn't update your dependencies.

The error Dependabot encountered was:

go: github.com/aspenmesh/[email protected]: invalid version: git fetch -f origin refs/heads/*:refs/heads/* refs/tags/*:refs/tags/* in /opt/go/gopath/pkg/mod/cache/vcs/132051b2a28160ffd7d3cdcd980555419efe3c94db2bb5240665f3540e886e36: exit status 128:
	fatal: could not read Username for 'https://github.com': terminal prompts disabled

If you think the above is an error on Dependabot's side please don't hesitate to get in touch - we'll do whatever we can to fix it.

View the update logs.

Desired Behavior
Meshery users, particularly those running Docker Desktop can benefit from multi-platform images of Meshery Server.

Implementation
Refactor existing stable and edge build and release workflows to use docker-build-push actions. See https://github.com/meshery/meshery/blob/master/.github/workflows/build-and-release-dde.yml as an example.

Be aware of local binaries and their needs:

1. layer5/kubeopenapi-json

Acceptance Tests

1. platform: linux/amd64,linux/arm64 should both be supported.

[Optional] Alternatives
A brief description of any alternative solutions or features you've considered.

[Optional] Additional context
Add any other context or screenshots about the feature request here.

Contributor Resources

The meshery.io website uses Jekyll and GitHub Pages. Site content is found under the master branch.

• See the Contributing to Meshery.io Website section of the readme.md and other contributing instructions, too.
• See Meshery site designs in this Figma designfile. Fill-in the Layer5 Community Member Form and join the Layer5 Community Slack for access.

Current Behavior
Currently the slack.yml is outdated. Also there is no automated way of notifying the slack channel when a "good first issue" has been created.

Desired Behavior
Update slack.yml and add newcomer-alert.yml to the Github workflow.

Resources
Add the updated slack.yml file and the newcomer-alert.yml file to the .github/workflow folder.

Files needed:
https://github.com/meshery/meshery-istio/blob/master/.github/workflows/slack.yml
https://github.com/layer5io/layer5/blob/master/.github/workflows/newcomers-alert.yml

Current Behavior
This repo is a copy of the istio adapter, which is not an adapter template.

Desired Behavior

• Displace all istio references with nsx-sm.
• Adapter builds and is properly named.

Description
With the official naming of NSX Service Mesh now being Tanzu Service Mesh (I think), we should rename this repository and this adapter to suite.

Expected Behavior
This adapter and repository should be renamed to meshery-tanzu-sm.

Current Behavior
Each of the layer5 repositories needs releaseDrafter automation as had been done in the meshery project which takes care of drafting release notes.

Desired Behavior
Add ReleaseDrafter configuration yaml file & GitHub Action.

Additional context

ReleaseDrafter Configuration File
ReleaseDrafter GitHub Action

Contributor Resources

See layer5 contributing instructions

A new adapter is being created. Let's reserve port 10008 for NSX-SM.

Please update Meshery Docs with this number - https://meshery.layer5.io/docs/installation/adapters

Current State

The ISSUE_TEMPLATE inside .github directory are not updated with Contributor Guides

Desired State

You need to update entire Contributor Guides inside ISSUE_TEMPLATE with the following scripts:

#### [Contributor Guides](https://docs.meshery.io/project/contributing) and Resources
- 📚 [Instructions for contributing to documentation](https://docs.meshery.io/project/contributing/contributing-docs)
   - Meshery documentation [site](https://docs.meshery.io/) and [source](https://github.com/meshery/meshery/tree/master/docs)
- 🛠 [Meshery Build & Release Strategy](https://docs.meshery.io/project/build-and-release)
- 🎨 Wireframes and designs for Meshery UI in [Figma](https://www.figma.com/file/SMP3zxOjZztdOLtgN4dS2W/Meshery-UI)
- 🙋🏾🙋🏼 Questions: [Layer5 Discussion Forum](https://discuss.layer5.io) and [Layer5 Community Slack](http://slack.layer5.io)

Contributor Guides and Resources

• 📚 Instructions for contributing to documentation
  • Meshery documentation site and source
• 🛠 Meshery Build & Release Strategy
• 🎨 Wireframes and designs for Meshery UI in Figma
• 🙋🏾🙋🏼 Questions: Layer5 Discussion Forum and Layer5 Community Slack

How can we help?
A brief description of what question(s) you have and how we can help clarify.

Description

Expected Behavior
Should be a link to (https://hub.docker.com/r/layer5/meshery-nsx-sm)

Contributor Resources

The meshery.io website uses Jekyll and GitHub Pages. Site content is found under the master branch.

• See the Contributing to Meshery.io Website section of the readme.md and other contributing instructions, too.
• See Meshery site designs in this Figma designfile. Fill-in the Layer5 Community Member Form and join the Layer5 Community Slack for access.

Description
A Meshery logo is available. The old version of the logo used in the README should be displaced.

Expected Behavior
New Meshery logo should displace old logo with:

<a href="https://layer5.io/meshery"><img align="left" src="https://raw.githubusercontent.com/layer5io/meshery/master/ui/static/img/meshery-logo/meshery-logo-light-text.png"  width="25%" /></a>

Current Behavior
The adapter repo just contains a skeleton which is basically a clone of the Istio adapter

Desired Behavior
A fully functional adapter which works well with NSX

Current Behavior
Given the issues experienced with the Azure container action (https://github.com/layer5io/meshery-nsx-sm/actions/runs/61765240), let's try switching to Docker's official GitHub action.

Desired Behavior

• use https://github.com/marketplace/actions/build-and-push-docker-images for building and pushing container images to docker hub.

Current State:
The Meshery Logo isn't visible in Readme File

Desired State:
The logo to be visible :)

Contributor Resources

• Meshery documentation site
• Meshery documentation source
• Instructions for contributing to documentation

Current State

Meshery Adapter for Tanzu SM lists port 10010 as its reserved port. This conflicts with the Meshery Adapter for NGINX SM reserved port.

Desired State

Bump Tanzu SM out to 10011. Update this port here - Update https://github.com/meshery/meshery-tanzu-sm/blob/master/main.go

Contributor Guides and Resources

• 🛠 Meshery Build & Release Strategy
• 📚 Instructions for contributing to documentation
  • Meshery documentation site and source
• 🎨 Wireframes and designs for Meshery UI in Figma
• 🙋🏾🙋🏼 Questions: Layer5 Discussion Forum and Layer5 Community Slack

Description

Currently, we are using the Logo of Layer5 instead of Meshery. This repository is under the organization Meshery, so, there should be the image of Meshery.

How to resolve this?

• Go to .github and replace this welcome image with the new one:

• Make sure to display the images conditionally, based on the theme selected by user.
  Here's the sample code:

<picture>
  <source media="(prefers-color-scheme: dark)" srcset="https://raw.githubusercontent.com/GiorgosXou/Random-stuff/main/Programming/StackOverflow/Answers/70200610_11465149/w.png">
  <source media="(prefers-color-scheme: light)" srcset="https://raw.githubusercontent.com/GiorgosXou/Random-stuff/main/Programming/StackOverflow/Answers/70200610_11465149/b.png">
  <img alt="Meshery Logo" src="">
</picture>

New images are:

• Download these images, and upload with an appropriate name. Make sure to use conditional rendering as described above.

• After uploading the image, and removing the previous image, go to .github/config.yml folder and update the reference to previous image to the new image in the following part:

firstPRMergeComment: >
  Thanks for your contribution to the Layer5 and Meshery community! :tada:
   
  ![Congrats!](https://raw.githubusercontent.com/meshery/meshery.io/master/.github/welcome/Layer5-celebration.png)
    	   	    	    	 :star: Please leave a [star on the project](../stargazers). :smile:

Here, replace ![Congrats!](https://raw.githubusercontent.com/meshery/meshery.io/master/.github/welcome/Layer5-celebration.png) with the code

<picture>
  <source media="(prefers-color-scheme: dark)" srcset="https://raw.githubusercontent.com/GiorgosXou/Random-stuff/main/Programming/StackOverflow/Answers/70200610_11465149/w.png">
  <source media="(prefers-color-scheme: light)" srcset="https://raw.githubusercontent.com/GiorgosXou/Random-stuff/main/Programming/StackOverflow/Answers/70200610_11465149/b.png">
  <img alt="Shows a black logo in light color mode and a white one in dark color mode." src="https://user-images.githubusercontent.com/25423296/163456779-a8556205-d0a5-45e2-ac17-42d089e3c3f8.png">
</picture>

make sure to change the image sources with the path to image in the folder where you upload it.

• That's it.

Contributor Guides and Handbook

• 🛠 Meshery Build & Release Strategy
• 📚 Instructions for contributing to documentation
  • Meshery documentation site and source
• 🎨 Wireframes and designs for Meshery UI in Figma
• 🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

Description
This configuration is wrong - https://github.com/layer5io/meshery-tanzu-sm/blob/master/.github/config.yml#L17

Expected Behavior
The config should be the same at this one - https://github.com/layer5io/layer5/blob/master/.github/config.yml#L18-L22

It's ok to use a relative URL.

Screenshots

Desired Behaviour

Need to update Go to 1.21 in go.mod and in Dockerfile, and also Makefile

• Minor chore on updating meshkit and meshery-adapter-library

Dependabot can't resolve your Go dependency files.

As a result, Dependabot couldn't update your dependencies.

The error Dependabot encountered was:

go: github.com/aspenmesh/[email protected]: invalid version: git fetch -f https://github.com/aspenmesh/nsx-sm-client-go refs/heads/*:refs/heads/* refs/tags/*:refs/tags/* in /opt/go/gopath/pkg/mod/cache/vcs/132051b2a28160ffd7d3cdcd980555419efe3c94db2bb5240665f3540e886e36: exit status 128:
	fatal: could not read Username for 'https://github.com': terminal prompts disabled

If you think the above is an error on Dependabot's side please don't hesitate to get in touch - we'll do whatever we can to fix it.

View the update logs.

Current Behavior
This line identifies the reserved port number that this adapter is be listening on - https://github.com/layer5io/meshery-tanzu-sm/blob/master/main.go#L33. Currently, it is using port 10000. This needs to be changed to 10010.

Implementation

• Update main.go in this repo so that the adapter listens on the specific port reserved for it, which is port 10010.
• Update Meshery Docs so that the reserved network port documentation reflects use of port 10010- https://meshery.layer5.io/docs/architecture#network-ports

Description
The Community section in the README says "Access the Community Drive". There is a new procedure of having this automated based on the individual filling in a community member form

Expected Behavior
Update "Access Community Drive" to "To Access Community Drive, fill Community Member Form"

Screenshots

Resources
Refer to the Contributing guide

Enviroment:

• OS: [e.g. Ubuntu]
• Browser: [e.g. Chrome, Safari]
• Version: [e.g. 22]
• Device: [e.g. laptop, iPhone 8]

Current Behavior
Many of places in the workflows still mention go version 1.16 yet the adapters use go version 1.17

Desired Behavior
Workflows shouls also use go version 1.17

[Optional] Alternatives
A brief description of any alternative solutions or features you've considered.

[Optional] Additional context
Add any other context or screenshots about the feature request here.

Contributor Resources

The meshery.io website uses Jekyll and GitHub Pages. Site content is found under the master branch.

• See the Contributing to Meshery.io Website section of the readme.md and other contributing instructions, too.
• See Meshery site designs in this Figma designfile. Fill-in the Layer5 Community Member Form and join the Layer5 Community Slack for access.