meshbits / pirate-wallet-layouts Goto Github PK

I don't remember which video has it, but there is one time you'll see that the app opens without prompting for PIN or FaceID. I tried multiple times by closing the app and starting it again, and it opened the app to home screen without PIN every time.

Actual Design

https://www.figma.com/proto/kUcm7qs8KrR0yTbIHhBUWA/PW?page-id=0%3A1&node-id=180%3A6288&viewport=327%2C48%2C1&scaling=scale-down&starting-point-node-id=180%3A6284

Current Design

Items need to fix

• Logo Size
• 'Restore from' text and BG to separate the Restore section. Easy for us to just add the iCloud button in the future.

I noticed that request amount screen after receive button screen, now shows content fine on screen. But as compared to other font sizes on app, it's too small.

When you were entering three words - first box and the title was bigger than the other two. UI issue.

version: 1.0.0-1-2
hash: gbfce2fc

I noticed it always comes down

• after create new wallet.
• navigating/changing screens back and forth between home/history/settings and others.

if a wallet is in syncing mode or newly created/added", and someone tries to unlink it, it goes into an uninitialised state and had to nuke it on the next launch again.

Feedback:

I am unable to go back from this last screen from recover pass phrase screen.
There is NO Back button. And touch slide back doesn't respond.

Items that need to fix:

• Title Font color isn't ' E9E9E9'. Avoid using Pure white 'FFFFFF'
• Top Nav Button
• Title Font size
• Reduce margin in-between Title & sub title
• Animation isn't smooth & it must be without any jerks or delay (in a loop)

• Header must be top align
• Reduce text size of the content

Need to check rust and swift

Known issue.

Need to compare and see it nighthawk as well.

Error

2021-10-01 07:38:17.712705+0530 ECC-Wallet-no-logs[21614:3559897] Writing analzed variants.
2021-10-01 07:38:17.714668+0530 ECC-Wallet-no-logs[21614:3559897] Writing analzed variants.
2021-10-01 07:38:26.163816+0530 ECC-Wallet-no-logs[21614:3559897] changing items while animating can result in a corrupted navigation bar
Swift/ContiguousArrayBuffer.swift:593: Fatal error: Index out of range
2021-10-01 07:50:37.365336+0530 ECC-Wallet-no-logs[21614:3559897] Swift/ContiguousArrayBuffer.swift:593: Fatal error: Index out of range
(lldb) 

File PasscodeViewModel.updateLayout (isBackPressed)

Steps to reproduce

• Create New wallet
• Set New PIN
• type some & tap on the Back button and at the same time switch to other APP (back & forth)

APP crashed when I selected the Input field to enter a text.

I have tried 5-6 transactions yesterday, all went through - which is good, I am getting an exception at the end of it - it happened 2/6 times. I need to investigate that and fix.

• Back button isn't working
• Could you please keep the placement of all elements and style as it is as per Figma.
• BG graphic is missing
• Middle content (CODE) should slide from right to left on the 'Next' button click. (check prototype) and also add swipe functionality.

Transactions aren't grouped correctly under one head

background_sync_cancelled.txt

Uploading RPReplay_Final1632807463.mp4…

Feedback:

Request amount screen shows top text and button cut off from display.
The bottom number pad buttons looks like overlapping too.

FaceID seems to be working fine.
Opening Recovery phrase screen triggers FaceID.
I don't remember our chat regarding this, but I think it's best to just prompt for PIN for recovery passphrase. Even if FaceID is enabled, opening Recovery Phrase should prompt for PIN.

Feedback #2:

I changed PIN.
Entered previous pin. All 1s.
Set new pin. All 2s
repeat pin, All 2s.
got back to settings.
open recovery phrase.
Enter All 2s as PIN.
It says Invalid PIN.
Expected behaviour is it either shows seed phrase with new PIN input.

at the bottom there is Text overflow etc. It shouldn't be showing History button

.

is in Change PIN - if there is an invalid input, then it gets stuck there with valid data and override the actual pin code - thats a bug, i need to handle close button stuff here as well.

Feedback:

I'm also unable to change the Language from settings.
I tap on empty space right next to the language text, hoping it should select the option, but it doesn't. No response to the tap input.
I tap on the text and the screen goes away, showing settings screen.
I open "select Language" again and it still shows English as selected.
Tried the same steps again. Selected Russian.
Same behaviour.
Same steps and behaviour again selecting Spanish.
Then I go back to home. tab Recieve button. It now shows different language there.
I go back to settings, select language, and now it shows Spanish selected.

This screen requires lots of fixes.

• In Top Nav: The back button is missing.
• 'Change PIN' must be a part of the Nav-bar. Also, reduce the size as per design
• Instead of the 'Change PIN' text, I think only 'PIN' is sufficient on this screen because it's the first time for a user to set up a new PIN.
• Avoid using ALL CAPS in the title. Fix 'Set' text
• Move Entire middle content (including 'Set PIN' title, to the top.
• Fix font color & size, specially in sub-title & supportive text.
• Keypad: Margin in-between buttons is too much. Try to keep it within a range of user's thumb
• keypad: The button size is smaller & the text isn't in the center.
• keypad: Back icon isn't correct. We are using Line-icons and it's a filled one.
• Progress bar/Circles: Both, filled & empty, aren't in the same size and are not Vertically align.

Surprisingly, I could only for once see the screen showing recovery phrase if the wallet was restored with seed phrase. Next attempts also resulted in the exact same behaviour as with the wallet created with create new wallet process

.

Feedback:

I forgot/lost my seed phrase.
now when I go to recovery phrase, it asks PIN, I enter PIN, then the screen takes me right back to home screen.
Doesn't show me passphrase.

I needed to wipe this wallet and start fresh to test properly.
I did remove the app, and then install it from xcode, and then I see this behaviour.
It wasn't synced fully and now it's syncing with the network.

https://github.com/zcash/zcash-ios-wallet/issues/271