mertturkmenoglu / dsa-stack Goto Github PK

I was just wandering around and i just realised that delete function does not update the root of the tree, it occures to me that your code has what i call " Pass by value by using pointer " issue.

• If you look carefully 31 is the head of the tree and 32 is the node that is inorder successor of the root so when i delete id 31, delete function only changes the id of the root to the 32 but doesn't necessarily deletes the node.

• Indeed from the perspective i see, the problem arises even if you successfully delete the root inside of the delete function.

  • This is because when you delete the root of the tree you'll need to update the root but when the delete function returns the new node of the tree, the caller of the delete function, deleteUserHandler will take that node and put it into the struct node* root which is actually just a pointer created for this function inside of the stack, if you were to update this pointer what will happen is that the change to the pointer will be deleted after deleteUserHandler function terminates since this function only returns boolean value back. This is what i call as pass by value using pointers

  • To solve the issue you have a few options

    • deleteUserHandler returns the new root back to the caseHandlerFunction and this function returns to the main the root that we send from deleteUserHandler, not the parameter that it takes from the caller.

    • Better way to get around this problem is that making your root globally defined, or maybe File scope but definitely not as a parameter.

      • My Implementation of the same problem is here btw almost same but just delete function uses globally defined root