virtio-emulation's Issues
Unfreed pointer in mlx5_create_indirect_mkey
uint32_t *in = rte_zmalloc("in", in_size, 64);
Not being released anywhere.
mlx5_vdpa pmd to run only on top of BlueFieild & ConnectX6 VF
virtio-emulation/drivers/net/mlx5/mlx5_vdpa.c
Line 1366 in 17bc999
Need to remove all but the last (BF VF) and add ConnectX6 VF
merge mlx5dv_dev_obj pointer and virtq_id to mlx5_vdpa_devx_obj
We can merge the 2 above to mlx5_vdpa_devx_obj (like in the rest of the code)
unfreed (and rather redundant) inbox pointer use
virtio-emulation/drivers/net/mlx5/mlx5_vdpa.c
Line 618 in 17bc999
We don't free the in pointer, and it's kind of pointless.
We can just do (like in other places):
uint8_t in[MLX5_ST_SZ_DB(create_mkey_in) + translations_oct_size * MLX5_ST_SZ_DB(klm)]
React to failure when calling create_split_virtq
virtio-emulation/drivers/net/mlx5/mlx5_vdpa.c
Line 511 in 17bc999
We can now (since we have FW) Remove this and really react to failure in create_virtq path
Use info which already points to current virtq
virtio-emulation/drivers/net/mlx5/mlx5_vdpa.c
Line 434 in 17bc999
Mistake when extracting the RQT Context number in CREATE_RQT
virtio-emulation/drivers/net/mlx5/mlx5_vdpa.c
Line 224 in 17bc999
Should be create_rqt_out, rqtn
If doesn't affect anything since it's in the same location like TIRN in create_tir_out,
but still should be fixed
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.