I have autoSort turned on, and I get "Nothing to sort" error everytime I save a file which does not contain any namespaces. I believe this warning or error is not needed. It not actionable.

If there is nothing to sort, then thats not an error :-)

My legacy system have classes without namespaces and they can not be found with this tool.

It would be a nice addition to this great tool

Here's the error message https://prnt.sc/qr3vys

Import notifications seems to be a bit distracting :

Failure notifications are alright, but success notifications require a force close. I think its ideal to move it to the status bar at the bottom. Less distracting.

When trying to import a class to create the use statement, I get the following error: Class App\User not found. I'm probably doing something wrong on my end. Any thoughts? Thanks!

• Issue Type: Performance
• Extension Name: php-namespace-resolver
• Extension Version: 1.1.7
• OS Version: Windows_NT x64 10.0.17134
• VSCode version: 1.33.1

⚠️ Make sure to attach this file from your home-directory:
⚠️C:\Users\kunal\MehediDracula.php-namespace-resolver-unresponsive.cpuprofile.txt

Find more details here: https://github.com/Microsoft/vscode/wiki/Explain:-extension-causes-high-cpu-load

When I first import a function or const, it is usually placed in a separate block to the class imports, like so:

use Encase\Functional\Type;

use const Encase\Matching\Support\_;

use function Encase\Functional\map;
use function Encase\Matching\Support\_;
use function Encase\Matching\Support\match;
use function Encase\Matching\Support\pattern;

However, if I then use the "sort imports" feature, it sorts them, but doesn't make them one block, leading to an unexpected result:

use Encase\Functional\Type;

use function Encase\Functional\map;

use const Encase\Matching\Support\_;
use function Encase\Matching\Support\_;
use function Encase\Matching\Support\match;
use function Encase\Matching\Support\pattern;

The expected behaviour would be for "sort imports" to either close the blank lines between the blocks, or preserve each block and sort them independently to match the behaviour of "import class".

A feature I'd like to see and would find very useful would be the ability to scan a file for any imports that are unused, with options for either highlighting them (con: user has to manually remove them, pro: false positives caught by user) or optionally to auto-remove (con: potential for false positives).

Each time I save file new highlight is added on unused usings and not imported classes (highlight background gets less transparent and in hover new info item is added).

First save:

More "saves":

There is an issue in namespace generation when the project name contains one of the psr4 namespace.

"psr-4": {
   "App\\": "app/",
   "BackOffice\\": "Modules/BackOffice/"
}

Even though the correct namespace is App\Http\Middleware the extension generate it as App

Foo should be highlighted in this picture, right?

Hi,

this extension looks very promising! 👏

As almost every php project uses composer nowaday, and as psr-4 tends to be widely adopted too, should be cool to open composer.json to automatically implement the namespace of a newly created class, no?

I'm ok to help as I prefer by far this extension to bloated/complex extensions for php that we can found currently for VSCode.

Technically it didn't stop working. It simply pegs out my i7-6700 processor for a few minutes for one search. My repo isn't THAT big. Also, even after the processor stops being pegged out it still doesn't kill the process (rg.exe) or come back with the imported class.

Here's my VS Code environment:
Version: 1.29.1 (system setup)
Commit: bc24f98b5f70467bc689abf41cc5550ca637088e
Date: 2018-11-15T19:13:36.375Z
Electron: 2.0.12
Chrome: 61.0.3163.100
Node.js: 8.9.3
V8: 6.1.534.41
Architecture: x64

What do you think about to have a user setting for allow the highlihters run automatically on open and save?

"Unable to write to User Settings because namespaceResolver.exclude is not a registered configuration."
this happens with any of the settings.

edit: manually entering the settings into settings.json seems to work fine. Even the auto-complete

When highlightOnOpen or highlightOnSave is enabled and there is a type that is not imported then every text that matches type name is marked. Only that type should be highlighted.

First of all, I love the plugin. It does everything I'm used to with a similar Sublime plugin, but there is one thing that I think could be extremely helpful.

Primary Use Case:
Refactoring.

Example:
Developer writes a function, or set of functions somewhere, and later realize it's time to refactor some of the functions into a new class for whatever reason (decoupling, etc.). Developer goes through the new class with the copied functions re-importing namespaces with PHP-Namespace-Resolver, but overlooks a namespace or two.

Suggestion:
Add a "Import Missing Namespaces" action which would essentially go through any class references in the file (e.g. new MyClass, MyClass::whatever) and run the Import Namespace command on each, prompting Developer to choose the correct namespace if it finds any class references that are ambiguous.

A similar "Expand Missing Namespaces" could be added as well, for completeness, though I think Import would be used more often.

Every time you press Ctrl+Alt+U, the highlighted words get brighter and brighter to the point of hurting your eyes.

Also there's no way to get rid of unused imported classes without switching to another opened file.

When I use the command that is namespaceResolver.importAll, it will import classes from absolute and relative namespace.

Before I use the command namespaceResolver.importAll:

After I use the command namespaceResolver.importAll:

Hello,

Found this extension today and it looks great, thanks! One thing I noticed is that sorting doesn't work the way I expect it to. Sorting is done only on the classname, it excludes the namespace. So I get this result:

use SilverStripe\Admin\ABCThing;
use SilverStripe\ORM\DataObject;
use SilverStripe\Admin\ModelAdmin;

but I expect this:

use SilverStripe\Admin\ABCThing;
use SilverStripe\Admin\ModelAdmin;
use SilverStripe\ORM\DataObject;

• Issue Type: Bug
• Extension Name: php-namespace-resolver
• Extension Version: 1.1.7
• OS Version: Linux x64 4.20.13-200.fc29.x86_64
• VSCode version: 1.32.3

⚠️ We have written the needed data into your clipboard. Please paste! ⚠️

{
	"messages": [
		{
			"type": 1,
			"message": "Menu item references the same command as default and alt-command",
			"extensionId": {
				"value": "MehediDracula.php-namespace-resolver",
				"_lower": "mehedidracula.php-namespace-resolver"
			},
			"extensionPointId": "menus"
		},
		{
			"type": 1,
			"message": "Menu item references the same command as default and alt-command",
			"extensionId": {
				"value": "MehediDracula.php-namespace-resolver",
				"_lower": "mehedidracula.php-namespace-resolver"
			},
			"extensionPointId": "menus"
		},
		{
			"type": 1,
			"message": "Menu item references the same command as default and alt-command",
			"extensionId": {
				"value": "MehediDracula.php-namespace-resolver",
				"_lower": "mehedidracula.php-namespace-resolver"
			},
			"extensionPointId": "menus"
		},
		{
			"type": 1,
			"message": "Menu item references the same command as default and alt-command",
			"extensionId": {
				"value": "MehediDracula.php-namespace-resolver",
				"_lower": "mehedidracula.php-namespace-resolver"
			},
			"extensionPointId": "menus"
		},
		{
			"type": 1,
			"message": "Menu item references the same command as default and alt-command",
			"extensionId": {
				"value": "MehediDracula.php-namespace-resolver",
				"_lower": "mehedidracula.php-namespace-resolver"
			},
			"extensionPointId": "menus"
		},
		{
			"type": 1,
			"message": "Menu item references the same command as default and alt-command",
			"extensionId": {
				"value": "MehediDracula.php-namespace-resolver",
				"_lower": "mehedidracula.php-namespace-resolver"
			},
			"extensionPointId": "menus"
		},
		{
			"type": 1,
			"message": "Menu item references the same command as default and alt-command",
			"extensionId": {
				"value": "MehediDracula.php-namespace-resolver",
				"_lower": "mehedidracula.php-namespace-resolver"
			},
			"extensionPointId": "menus"
		}
	],
	"activationTimes": {
		"startup": false,
		"codeLoadingTime": 3,
		"activateCallTime": 0,
		"activateResolvedTime": 9,
		"activationEvent": "onLanguage:php"
	},
	"runtimeErrors": [
		{
			"name": "TypeError",
			"message": "Cannot read property 'document' of undefined"
		},
		{
			"name": "TypeError",
			"message": "Cannot read property 'document' of undefined"
		},
		{
			"name": "TypeError",
			"message": "Cannot read property 'document' of undefined"
		}
	]
}

on the image "Demo" it has like Import namespace. where as on the latest version, it doesn't have..

I keep getting these errors over and over again as I tab through open documents using this extension.

TypeError: Cannot read property 'document' of undefined
	at context.subscriptions.push.vscode.window.onDidChangeActiveTextEditor (/home/samuel/.vscode/extensions/mehedidracula.php-namespace-resolver-1.1.4/src/extension.js:66)
	at e.fire (/usr/share/code/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:44)
	at /usr/share/code/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:620
	at e.fire (/usr/share/code/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:44)
	at e.$acceptDocumentsAndEditorsDelta (/usr/share/code/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:527)
	at t._doInvokeHandler (/usr/share/code/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:644)
	at t._invokeHandler (/usr/share/code/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:643)
	at t._receiveRequest (/usr/share/code/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:642)
	at t._receiveOneMessage (/usr/share/code/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:641)
	at /usr/share/code/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:638
	at /usr/share/code/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:38
	at e.fire (/usr/share/code/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:44)
	at a (/usr/share/code/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:170)
	at Socket.f._socketDataListener (/usr/share/code/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:170)
	at Socket.emit (events.js:182)
	at addChunk (_stream_readable.js:279)
	at readableAddChunk (_stream_readable.js:264)
	at Socket.Readable.push (_stream_readable.js:219)
	at Pipe.onread (net.js:636)

Hey, not sure if this has been suggested before but it might be useful if we could get a command to add the namespace declaration to the current file.

Say the working path were "App/Models/User.php" then the command would put "namespace App\Models;" at the top of the file.

I know PHPCompanion in Sublime supports that feature, granted I'm not sure how difficult that is to implement though. I personally just find it pretty useful and I'm sure some others would as well.

Thanks much.

When highlightOnOpen or highlightOnSave is enabled, using for types used in phpDocs are marked as not used (if there is no other use of them in code).

When I write a class and execute namespaceResolver.expand, the cursor stays on its previous position (or rather is moved to its previous position, at least it looks that way), instead of at the end of the expanded class. Example:

Typically I want to continue writing at the end of the expanded class name. It would be nice if the cursor was not moved back to its original position after running namespaceResolver.expand :)

This is pretty nice, the only reason I've ever stayed away from other editors than Netbeans is that they never had such good auto-import functionality. Neither does VSCode yet but it could get there with this plug in!

One feature that is key is to be able to auto-resolve all referenced classes instead of having to point to a class and then alt+ctrl+i however I see this is already mentioned in another feature request.

What would be really useful is also to be able to add paths of other sources, for example now my PHP project includes files from a directory that is not part of the project (a common repository), when trying to resolve a class from there I get an error that the class is not found. In Netbeans this problem is resolved by specifying paths of external sources and scanning them as well.

Thanks in advance, awesome work!

Hello,

First of all thanks for this very nice extension and made it available for us.

I would like to propose a litle improvment which will make life more easier for coders.

When typing in vscode \Symfony\Component\Console\Helper\SymfonyQuestionHelper, right click on the part SymfonyQuestionHelper and choosing "Import namespace" should import \Symfony\Component\Console\Helper\SymfonyQuestionHelper and reduce the line to SymfonyQuestionHelper.
If importing \Symfony\Component\Console\Helper, it should reduce it to Helper\SymfonyQuestionHelper.
You get the idea i think ; )

Actually we need to reduce it manually, it would be great if after import, line is reformated/collapsed.
Same with "Import all", it could parse the file, import all namespace and reduce/collapse everywhere they are called.

I hope it is a good idea.

Thanks.

• Issue Type: Bug
• Extension Name: php-namespace-resolver
• Extension Version: 1.1.8
• OS Version: Linux x64 5.3.0-19-generic
• VSCode version: 1.39.2

⚠️ We have written the needed data into your clipboard. Please paste! ⚠️

Hey this is similar to #5.

On my end the hotkeys do not work with classes in the vendor folder, but works fine with classes in the current project. The issue, from what I found, is related to .gitignore - if I remove the vendor folder from it, then everything works fine. I tried replacing the intellisense plugin (tried PHP IntelliSense, IntelliSense-crane and Intelephense), without success.

Has this occurred in the past or is it resolvable with a specific configuration?

Version 1.24.0-insider
Commit 912fff91ac4ff1bff9695e8da69abd729f7ae956
Date 2018-05-18T05:11:07.195Z
Shell 1.7.12
Renderer 58.0.3029.110
Node 7.9.0
Architecture x64

Please reconsider the default keybings this extension uses. For e.g. F1 is already bound to "Show All Commands" by default and it's not good overriding such a commonly used binding.

IMHO it would be better to use a key combination by default for all the commands this extension provides.

I often change a namespace of one of my files and therefore need to update the use statement in the file that uses it.

Right now this is not possible with this plugin, because the class already has a use statement and will ask for an alias.

I am thinking that if you do not enter anything in the "Enter an alias"-box, it will instead replace the use statement.

The box could say "Enter an alias or leave it empty to replace"

I would gladly make a pullrequest if you accept this feature.

I tried this package in my Symfony application and it does work for classes inside my app, but I can't import things from the vendor folder (e.g. Doctrine, Symfony, etc):

Class 'Request' not found.

Maybe similar to #5. I'm using PHP IntelliSense and already tried reinstalling it as mentioned in the other issue.

Hello,

Namespace are sorted by lenght by default. I really think it is more usefull to do it alphabeticaly, as it is more meaningfull to have namespace grouped.
Is there any reason it is by lenght by default ?
If not, maybe it could be changed to alphabetically by default.

I know there is a settings, but i will prevent to have to have to edit the configuration each time it is installed on some computers.

Thanks.

Hi,

I noticed the context menu entries were removed in b989314.

Are there any plans to bring this back as an option/provide an alternative?

Thanks!

It worked super fast but after updating to visual studio 1.29.1 x64 it takes up to 1 - 2 minutes to find the namespaces. I use windows 10 x64

I think highlighting not imported classes would be a nice feature. If you agree I can implement it.

This was working fine prior to the last VSCode update.

I have two autoload-folders:

        "psr-4": {
            "App\\": "app/",
            "Domain\\": "src/"
        },

Namespace had no issue figuring out what folder I was in and using the right namespace, but now, it only takes whatever the first in the list is. So if I'm working in src/foo/bar the namespace should be Domain\Foo\Bar what I actually get is App\src\Foo\Bar

And to confirm, I changed the order of my psr-4 json there and if I change the order still gets it wrong, just now with the other name first.

Maybe I messed something up? I did run composer du too hoping that would help pick things up, but something seems to be amiss. Let me know if you need other information.

• Issue Type: Bug
• Extension Name: php-namespace-resolver
• Extension Version: 1.1.4
• OS Version: Darwin x64 17.7.0
• VSCode version: 1.32.0-insider

{
	"activationTimes": {
		"startup": false,
		"codeLoadingTime": 120,
		"activateCallTime": 6,
		"activateResolvedTime": 4,
		"activationEvent": "onLanguage:scss"
	},
	"runtimeErrors": [
		{
			"name": "Error",
			"message": "Language client is not ready yet"
		}
	]
}

I would like to recommend two improvements that might streamline the use of the plugin:

1. Automatically trim the namespace from the class name when importing, if it exists. For example

$test = new \App\User;
//should become, after import:
$test = new User;

2. If the class already has the namespace preceding it, automatically capture that and use it to resolve which class to import, instead of providing the drop-down window to the user.

Thanks for listening, keep up the good work!
~Mike

Brilliant extension. I use it a lot. However, with the recent upgrade to VS Code, it's stopped working: no errors, just doesn't do anything.

Here's my VS Code environment:
Version 1.23.0
Commit 7c7da59c2333a1306c41e6e7b68d7f0caa7b3d45
Date 2018-05-03T16:44:55.614Z
Shell 1.7.12
Renderer 58.0.3029.110
Node 7.9.0
Architecture x64

Any suggestions?

for example

i store model User in variable

$model = 'User';

i pass $user to other page
and i want use lik this $model::all()
because the model it will be denamic
but the extention PHP-Namespace-Resolver
remove the model Because his name not on top
he don't now that model saved in variable $model how can i stop removing auto

Sometimes we only have 1 reference to a class, and importing as a use statement can get large pretty quick

Can we have a shortcut to prepend the namespaces to the class, for example

before the append

public function index(User $user)
{

}

after prepend

public function index(App\Models\User $user)
{

}

Hi, can this package create automatic use statements when adding classes from Intellisense? That is one of the features preventing me from moving from Atom to VS Code -- would love to find a way to have VSCode create use statements instead of resolving the class name inline.

Sorry if this is not what your package was designed to do, but I thought I would ask. :) Thanks!

Is it possible to disable the messages after using this plugin?

Thanks!

Hi

Maybe I just don't understand glob matching that well but how do I exclude multiple folders?
Getting a VS Code settings error when I try the following

"namespaceResolver.exclude": [
        "**/node_modules/**",
        "**/vendor/{local package name}/vendor/**"
    ]

Hi, this package is great for sorting my imports using a keyboard shortcut. I’d like to sort imports on save as well.

I’ve tried adding this to my user settings:

"[php]": {
    "editor.codeActionsOnSave": {
        "namespaceResolver.sort": true
    }
}

But imports don’t sort on save as expected. Do I need to do anything else to get the namespaceResolver.sort command to run when a .php file is saved?

First I want to thank you for this extension it's awesome, but recently it stopped working. When I run the import class or expand class command nothing happens as you can see here:

Update: I debugged the extension and the problem seems to be in this line:

let namespaces = await this.findNamespaces(resolving, files);

after stopping the execution there, the debug console shows rejected promise not handled within 1 second.