Code Monkey home page Code Monkey logo

dc-pattern-lib-v2's People

Contributors

dependabot[bot] avatar emaildano avatar hideokamoto avatar

Stargazers

avatar

Watchers

avatar avatar avatar avatar avatar avatar avatar avatar avatar

Forkers

gaybro8777

dc-pattern-lib-v2's Issues

Not working in v1.5

When we update to the version, our React application has been broken.

×
TypeError: Cannot read property 'createElement' of undefined
push../node_modules/dc-pattern-lib/lib/DashboardDimmer.js.exports.default
src/DashboardDimmer.tsx:14
  11 |     return (react_1.default.createElement(reactstrap_1.Modal, { centered: true, isOpen: isOpen, toggle: toggle, contentClassName: "text-center border-0 shadow-none bg-transparent" },
  12 |         react_1.default.createElement("div", { className: "spin mx-auto", style: { width: '40px' } },
  13 |             react_1.default.createElement(Logos_1.default, { logoStyle: "logomark-light" }))));
> 14 | });
  15 | //# sourceMappingURL=DashboardDimmer.js.map
View compiled

Step to reproduce

$ yarn add [email protected]
$ rm -rf node_modules
$ yarn
$ yarn start

Tested version

  • 1.5.3: NG
  • 1.5.2: NG
  • 1.5.1: NG
  • 1.5.0: NG
  • 1.4.3: OK

DashboardAlert broke our dashboard

After replaced from Alert to DashboardAlert, our dashboard notification has been broken.
We re-replace the component to Alert.

If you fixed the issue, we can use it again.

Our code

Wrapper

const ExampleWrapperComponent = (props) => {
    const { type, message, title, hint } = props;
    return (
      <DashboardAlert type={type} isOpen={this.state.visible} toggle={this.onDismiss}>
        <b className="alert-heading">{title}</b>
        <br />
        {message}
        {hint}
      </DashboardAlert>
    );
  }

Usage

<ExampleWrapperComponent type="danger" title="Failed to start WordPress" message="Error Code: ERR" />

Expect

スクリーンショット 2020-01-16 13 03 08

Actual

スクリーンショット 2020-01-16 13 04 39

Select option's text is hidden

Expected

Show select option label text
スクリーンショット 2020-06-04 17 31 37

Actual

Hidden
スクリーンショット 2020-06-04 17 32 05

Problems

The padding is larger than the tag's height.
スクリーンショット 2020-06-04 17 33 08

Solution

Should we update the tag's padding (vertical) smaller.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.