Code Monkey home page Code Monkey logo

nodejs_oauth2example's Introduction

nodejs_oauth2example's People

Contributors

meeks91 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

nodejs_oauth2example's Issues

Issue saving access token

I am new to Node JS and GitHub. I found your example very enlightening. I hope to tailor this for my needs but wanted to report a problem I had saving a token using your code.

I had to make the following two changes:

  • In your "accessTokenModel.js", function "saveAccessToken", I had to modify the call to: "accessTokensDBHelper.saveAccessToken(accessToken, user.username, callback)", and
  • In your "accessTokensDBHelper.js", function "saveAccessToken", I had to modify the SQL query to INSERT INTO access_tokens (access_token, user_id) VALUES ("${accessToken}", "${userID}") ON DUPLICATE KEY UPDATE access_token = "${accessToken}";

I haven't examined this much so I am not certain if this is the correct fix.

Serious security issues

Using SHA for password hashing, no salt, leaking whether user is registered or not, no account verification (eg via email), no ability to reset passwords

Since this application is a starter for an application about implementing OAuth providers, I'm concerned about how this could cause huge issues if someone without much security knowledge used it as-is on their oauth provider project.

Very broken

DO NOT USE THIS REPO

There are many issues with callbacks being used instead of promises. There's syntax errors too. Not ES6 compatible.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.