mediassumani / cs-1.3 Goto Github PK
View Code? Open in Web Editor NEWNotes, Exercises, and projects for my CS 1.3 class at @makeschool
cs-1.3's Introduction
cs-1.3's People
Contributors
Watchers
cs-1.3's Issues
Feedback: Second Challenge Submission
- Nice work on your stack and queue classes. While everything works, you might consider using other syntax in the future, such as
[-1]to access the last item in a list, or justpop()to pop the last element. In addition, in your ArrayQueue dequeue, you can simplify your O(n-k) to just O(n) because you are popping the element at index 0 every time. - In your Set, watch out for un-optimizing code. Wherever you're checking if an item is in a set, you are moving it from a hash table into a list and looking into the list (O(n) complexity worst case). You can just use a method on your hash table to see if the item is in the set (close to, if not, O(1) complexity).
- Your comments in LinkedStack pop were very helpful, and your Set tests are pretty good. If you want to write more tests, I would suggest trying to write tests that include integers as well.
Feedback: First Challenge Submission
- Nice doc strings! I appreciate that you've taken the time to do them as this is probably the last thing people will do in their code.
- I saw that you were able to use the find_index function in contains. Considering that find_indexes and find_all_indexes have the same complexities, do you think one of those functions could be used for the other? I would also encourage you to try refactoring the string searches to avoid string splicing.
- Your code formatting is very nice; the comments and spacing help a lot in reading your solutions.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.