mdbraber / acme.sh-debian Goto Github PK

You should use HTTPS here:

Github redirects to HTTPS, but some man in the middle could still intercept this and redirect you elsewhere before that happens.

The content of debian/compat is 10, but the build-dependency on debhelper is just >= 9. That might cause build failures if a early debhelper version 9.x is installed (later ones, shortly before the release of debhelper 10, the 9.x versions had beta support for compat level 10) and doesn't make sense either.

I found out that this repository doesn't have a license yet when my repository was trying to reference account.conf from here, and this May lead to some copyright issues

Recommend the same license for acme.sh repositories.

Makefile contains this line:

dpkg-buildpackage -us -uc -b --target-arch amd64

This is wrong from multiple points of view:

• There is nothing architecture-dependent (it's a shell script after all!), so the package should be archicture all.
• The architecture is already specified via debian/control, not the commandline. Should be all, not any there, too.
• You don't know on which architecture the user will later use this script. Won't be installable on a Raspberry Pi which either has architecture armhf or arm64. The Architecture: any in debian/control already chooses the proper target architecture (the one of the host) by default, if you don't want to do cross-compiling for another architecture.

So please:

• Just drop the --target-arch amd64 from Makefile completely.
• Change Architecture: any to Architecture: all in debian/control.