Code Monkey home page Code Monkey logo

module-build's People

Contributors

frenzymadness avatar hroncok avatar mcurlej avatar mkulik-rh avatar

Stargazers

 avatar  avatar  avatar  avatar

Watchers

 avatar

module-build's Issues

Filtered binary packages are not excluded from artifacts

If a YAML file lists binary packages in /data/filter/rpms list, those are kept /data/artifacts/rpms.

A reproducer: Build a (1f38p536) context from https://src.fedoraproject.org/modules/perl-CGI/raw/4.54/f/perl-CGI.yaml with:

  filter:
    rpms:
    - perl-CGI-tests
    - perl-Sub-Uplevel
    - perl-Test-Deep
    - perl-Test-Warn

The RPM packages are properly removed from the repository:

.
./perl-CGI:4.54:20220921082434:1f38p536:x86_64.modulemd.yaml
./perl-CGI-4.54-4.module_rawhide+1f38p536.noarch.rpm
./perl-CGI-4.54-4.module_rawhide+1f38p536.src.rpm
./repodata
./repodata/03ab36b8f3cd1da7c650c40be6353a84168f6c52f3e3cb4987c75976561dfe3d-primary.sqlite.bz2
./repodata/3ebcebd2e04ef1bb3551a9cab959aa2da668dfa3ccf6def846d044fdd3815562-filelists.sqlite.bz2
./repodata/45b897c1cbe595943ea9898de24fbaa7a9019b1e96b3a146dba507b82f5a6ad8-other.xml.gz
./repodata/61e54a41f2549e2d13a171b9864a8c802c975992dc6c64100853f9d5a76fb42a-other.sqlite.bz2
./repodata/c956721cebd002a411f56ba9799ddaccd2e62b9064d1acc71f0115959e900ece-primary.xml.gz
./repodata/cb749b4906a62a5c8045483b2e9f0665f7fb938ed7777dbfcd3c1430f5c66dd0-modules.yaml.gz
./repodata/d009f7ed3c6d969906c90d9dd0edf6a87ca2a9f450d3e4350ae12483809b13e3-filelists.xml.gz
./repodata/repomd.xml

But ./repodata/cb749b4906a62a5c8045483b2e9f0665f7fb938ed7777dbfcd3c1430f5c66dd0-modules.yaml.gz still lists them among artifacts:

  artifacts:
    rpms:
    - perl-CGI-0:4.54-4.module_rawhide+1f38p536.noarch
    - perl-CGI-0:4.54-4.module_rawhide+1f38p536.src
    - perl-CGI-tests-0:4.54-4.module_rawhide+1f38p536.noarch
    - perl-Sub-Uplevel-1:0.2800-18.module_rawhide+1f38p536.noarch
    - perl-Sub-Uplevel-1:0.2800-18.module_rawhide+1f38p536.src
    - perl-Test-Deep-0:1.130-9.module_rawhide+1f38p536.noarch
    - perl-Test-Deep-0:1.130-9.module_rawhide+1f38p536.src
    - perl-Test-Warn-0:0.37-1.module_rawhide+1f38p536.noarch
    - perl-Test-Warn-0:0.37-1.module_rawhide+1f38p536.src

Better name for TestException

class TestException(Exception):
pass

pytest tries to collect this exception and emit this warning:

PytestCollectionWarning: cannot collect test class 'TestException' because it has a __init__ constructor (from: tests/test_cli.py)
    class TestException(Exception):

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.