Code Monkey home page Code Monkey logo

musiclib's People

Contributors

dependabot[bot] avatar mctofu avatar

Stargazers

 avatar  avatar

Watchers

 avatar  avatar  avatar

musiclib's Issues

Scanning more extensions?

I noticed that files with .ape, .opus and .wv (WavPack) extensions were not listed by deadbeef-library. After a quick inspection:

musiclib/scan.go

Lines 15 to 21 in 40d61b3

var tagExts = map[string]struct{}{
".mp3": {},
".m4a": {},
".flac": {},
".ogg": {},
".wav": {},
}

I tried to add said extensions to the list and re-building musiclib-grpc-server:

var tagExts = map[string]struct{}{
	".mp3":  {},
	".m4a":  {},
	".flac": {},
	".ogg":  {},
	".wav":  {},
+	".ape":  {},
+	".opus": {},
+	".wv":   {},
}
❯ go build -o musiclib-grpc-server ./cmd/server

However, the following error keeps being printed for any .opus file detected:

❯ journalctl --user -u musiclib-grpc-server.service

musiclib-grpc-server[402651]: 2022/09/22 16:23:51 failed to read tag from /path/to/file.opus: expected 'vorbis' identification type 1
[...]
musiclib-grpc-server[402651]: 2022/09/22 16:26:17 Scanned root paths
musiclib-grpc-server[402651]: 2022/09/22 16:26:17 Indexed artist/album
musiclib-grpc-server[402651]: 2022/09/22 16:26:17 Indexed file paths
musiclib-grpc-server[402651]: 2022/09/22 16:26:17 Indexed genres
musiclib-grpc-server[402651]: 2022/09/22 16:26:17 Indexed years
musiclib-grpc-server[402651]: 2022/09/22 16:26:18 Indexed modified dates
musiclib-grpc-server[402651]: 2022/09/22 16:26:18 Loaded library
musiclib-grpc-server[402651]: 2022/09/22 16:26:18 Starting server

The .opus files are properly tagged and DeaDBeeF recognizes them when I add them to a playlist. I'm using Kid3 for tagging and I cannot add any "Tag 1" entry with opus files, only "Tag 2", which are then displayed as "Tag 2: Vorbis":

image

Regarding .ape and .wv files, no error is printed when starting the server, but they're still not displayed in DeaDBeeF despite being added to the list in scan.go file. Kid3 shows "Tag2: APE" for both .ape and .wv files (properly tagged too and correctly parsed by DeaDBeeF):

image
image

Any suggestion on how I could achieve this?

Thanks.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.